Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check maven central distribution requirements #700

Closed
4 tasks
peternied opened this issue Oct 5, 2021 · 4 comments
Closed
4 tasks

Check maven central distribution requirements #700

peternied opened this issue Oct 5, 2021 · 4 comments
Labels
enhancement New Enhancement good first issue Good for newcomers hacktoberfest Global event that encourages people to contribute to open-source.

Comments

@peternied
Copy link
Member

peternied commented Oct 5, 2021

Follow up from #699

At the end of the release process we were surprised by some checks that failed, we should make sure these checks can be enforced before we are in the middle of a release or at least have a best effort to minimize these issues.

Add a check next to https://github.com/opensearch-project/opensearch-build/tree/main/bundle-workflow/src/build_workflow/opensearch that verifies that:

  • Every .jar came with a corresponding .md5 and .sha1 signature file.
  • Every artifact comes with a corresponding sources jar.
  • Every artifact comes with a corresponding javadoc jar.
  • POM contains project name, description, URL, license information, SCM URL, and developer information.
@peternied peternied added the enhancement New Enhancement label Oct 5, 2021
@peternied peternied changed the title [Distribution] Maven Central requirements should be checked and notified before uploading to Sonatype [Distribution] Maven Central requirements should be checked Oct 5, 2021
@dblock dblock added v1.2.0 OpenSearch 1.2 version good first issue Good for newcomers labels Oct 6, 2021
@dblock dblock changed the title [Distribution] Maven Central requirements should be checked Check maven central distribution requirements Oct 6, 2021
@peternied peternied removed the v1.2.0 OpenSearch 1.2 version label Nov 16, 2021
@prudhvigodithi
Copy link
Member

Hey @peternied with existing automation every published jar has .md5, .sha1, sha256, sha512 and .asc extension
https://repo1.maven.org/maven2/org/opensearch/opensearch/1.3.2/

it has sources and javadoc jar as well
https://repo1.maven.org/maven2/org/opensearch/opensearch-job-scheduler/2.0.1.0/

Pom extensions for jar and zip are customizable
Example https://github.com/opensearch-project/job-scheduler/blob/main/build.gradle#L86-L117
https://github.com/opensearch-project/job-scheduler/blob/main/build.gradle#L119-L128

Thank you

@peternied
Copy link
Member Author

@prudhvigodithi This issue was opened to make sure those requirements are enforced before being uploaded to maven - if not fail with an appropriate error message. I think this issue is still relevant, what do you think?

@prudhvigodithi
Copy link
Member

@peternied the requirements are already deep in the automation, I'm fine to have an extra workflow/checks to ensure those are there, but if a team want to have a new POM XML extension there are chances the workflow has to be extended, also not always sources and javadoc jar are required, its up to the team (to remove the the shadow jars), I'm open for a discussion on this, Adding @dblock @bbarani @peterzhuamazon @gaiksaya @zelinh

@bbarani bbarani added the hacktoberfest Global event that encourages people to contribute to open-source. label Oct 5, 2022
@bbarani
Copy link
Member

bbarani commented Nov 21, 2022

Closing this issue as it will be tracked via #2928

@bbarani bbarani closed this as completed Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement good first issue Good for newcomers hacktoberfest Global event that encourages people to contribute to open-source.
Projects
None yet
Development

No branches or pull requests

4 participants