Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] Release version 1.3.7 #2742

Closed
33 of 40 tasks
github-actions bot opened this issue Oct 15, 2022 · 18 comments
Closed
33 of 40 tasks

[RELEASE] Release version 1.3.7 #2742

github-actions bot opened this issue Oct 15, 2022 · 18 comments
Assignees

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2022

Release OpenSearch and OpenSearch Dashboards 1.3.7

I noticed that a manifest was automatically created in manifests/1.3.7. Please follow the following checklist to make a release.

How to use this issue

This Release Issue

This issue captures the state of the OpenSearch release, its assignee is responsible for driving the release. Please contact them or @mention them on this issue for help. There are linked issues on components of the release where individual components can be tracked. More details are included in the Maintainers Release owner section.

Release Steps

There are several steps to the release process, these steps are completed as the whole release and components that are behind present risk to the release. The release owner completes the tasks in this ticket, whereas component owners resolve tasks on their ticket in their repositories.

Steps have completion dates for coordinating efforts between the components of a release; components can start as soon as they are ready far in advance of a future release.

Component List

To aid in understanding the state of the release there is a table with status indicating each component state. This is updated based on the status of the component issues.

Preparation

  • Assign this issue to a release owner.
  • Declare a pencils down date for new features to be merged.
  • Dec 6th is pencils down date for feature freeze.
  • Update the Campaigns section to include monitoring campaigns during this release.
  • Update this issue so all __REPLACE_RELEASE-__ placeholders have actual dates.
  • Document any new quality requirements or changes.
  • Finalize scope and feature set and update the Public Roadmap.
  • Create a release issue in every component repo that links back to this issue, update Components section with these links.
  • Ensure the label is created in each component repo for this new version, and the next minor release. Create a version label
  • Ensure that all release issues created above are assigned to an owner in the component team.
  • Increase the build frequency for the this release from once a day (H 1 * * *) to once every hour (H/60 * * * *) in jenkinsFile

CI/CD (Feature Freeze) - 11/29/2022 - 12/06/2022

  • Create Jenkins workflows that run daily snapshot builds for OpenSearch and OpenSearch Dashboards.
  • Increment each component version to 1.3.7 and ensure working CI in component repositories.
  • Make pull requests to add each component to manifests/1.3.7/opensearch-1.3.7.yml and manifests/1.3.7/opensearch-dashboards-1.3.7.yml with the corresponding checks.
  • OpenSearch / OpenSearch-Dashboards core and components teams finalize their features
  • OpenSearch / OpenSearch-Dashboards core cut branch <MajorVersion>.<MinorVersion> early.

Campaigns

opensearch-project/opensearch-plugins#181

Code Complete - 11/29/2022 - 12/06/2022

Release testing - 12/07/2022 - 12/09/2022

  • All components should have cut branch <MajorVersion>.<MinorVersion> for the release.
  • Declare a release candidate build, and provide the instructions with the release candidates for teams on testing (REPLACE_RELEASE-minus-8-days).
  • Stop builds for this version of OpenSearch and/or OpenSearch Dashboards in order to avoid accidental commits going in unknowingly. Restart only if necessary else manually run the build workflow and declare new release candidate.
  • Sanity Testing (REPLACE_RELEASE-minus-8-days - REPLACE_RELEASE-minus-6-days): Sanity testing and fixing of critical issues found by teams. Teams test their components within the distribution, ensuring integration, backwards compatibility, and perf tests pass.
  • Publish all test results in the comments of this issue.

Performance testing validation - 12/07/2022 - 12/09/2022

  • Performance tests do not show a regression
  • Longevity tests do not show any issues

Release - 12/12/2022 - 12/13/2022

Post Release

  • Create release tags for each component (Jenkins job name: release-tag-creation).
  • Replace refs in manifests/1.3.7 with tags and remove checks.
  • If this is a major or minor version release, stop building previous patch version.
  • Generate distribution release notes reviewed by PM team for opensearch-build repository.
  • Increment version for Helm Charts (sample PR) for the 1.3.7 release.
  • Increment version for Ansible Charts (sample PR) for the 1.3.7 release.
  • Prepare for next patch release by incrementing patch versions for each component.
  • Update this template with any new or missed steps.
  • Create an issue for a retrospective, solicit feedback, and publish a summary.

Components

Replace with links to all component tracking issues.

Component On track Release Notes
{COMPONENT_ISSUE_LINK} {INDICATOR}} {STATUS}
Legend

Symbol Meaning
🟢 On track with overall release
🟡 Missed last milestone
🔴 Missed multiple milestones

@github-actions github-actions bot added release untriaged Issues that have not yet been triaged v1.3.7 labels Oct 15, 2022
@rishabh6788 rishabh6788 removed the untriaged Issues that have not yet been triaged label Oct 25, 2022
@rishabh6788 rishabh6788 self-assigned this Oct 25, 2022
@peterzhuamazon peterzhuamazon pinned this issue Nov 18, 2022
@peterzhuamazon
Copy link
Member

Existing issues:

  1. Windows or not
  2. OpenSearch Dashboards map hoverover broken [BUG] OpenSearch-Dashboards#2996
  3. If 1, security needs to be extended to Monday Backport Windows support to 1.x branch security#2281

@peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon self-assigned this Dec 2, 2022
@peterzhuamazon
Copy link
Member

peterzhuamazon commented Dec 6, 2022

@kavilla
Copy link
Member

kavilla commented Dec 6, 2022

Not sure if I see the cause of failure here: opensearch-project/OpenSearch-Dashboards#3030. Seems like it built the artifact and still outputted an error.

@peterzhuamazon
Copy link
Member

Not sure if I see the cause of failure here: opensearch-project/OpenSearch-Dashboards#3030. Seems like it built the artifact and still outputted an error.

@kavilla I post the error msg in that issue, please check.

@peterzhuamazon
Copy link
Member

@peterzhuamazon
Copy link
Member

KNN temporarity disable the tests to get through the build, will contact @naveenpajjuri and @rishabh6788 on the next step.
opensearch-project/k-NN#656

Thanks

@rishabh6788
Copy link
Collaborator

Release testing

We have release candidates built and ready for testing.


OpenSearch docker

  • Start without security
    Docker command docker pull opensearchstaging/opensearch:1.3.7.6672 && docker run -it -d -p 9200:9200 -e "discovery.type=single-node" -e "DISABLE_SECURITY_PLUGIN=true" opensearchstaging/opensearch:1.3.7.6672
    Connect command curl http://localhost:9200
  • Start with security
    Docker command docker pull opensearchstaging/opensearch:1.3.7.6672 && docker run -it -d -p 9200:9200 -e "discovery.type=single-node" opensearchstaging/opensearch:1.3.7.6672
    Connect command curl --insecure https://admin:admin@localhost:9200

OpenSearch-Dashboards docker

  • Start without security
    Docker command docker pull opensearchstaging/opensearch-dashboards:1.3.7.4664 && docker run -it -d --network="host" -e "DISABLE_SECURITY_DASHBOARDS_PLUGIN=true" opensearchstaging/opensearch-dashboards:1.3.7.4664
    URL http://localhost:5601
  • Start with security
    Docker command docker pull opensearchstaging/opensearch-dashboards:1.3.7.4664 && docker run -it -d --network="host" opensearchstaging/opensearch-dashboards:1.3.7.4664
    URL http://localhost:5601

Use below artifacts to deploy OpenSearch and OpenSearch Dashboards on different platforms

OpenSearch - Build 6672

OpenSearch Dashboards - Build 4664

How to install via yum, tarball, windows etc?

@rishabh6788
Copy link
Collaborator

rishabh6788 commented Dec 8, 2022

@Angie-Zhang
Copy link
Contributor

Integration tests for Linux are failing for below components: X64: https://build.ci.opensearch.org/blue/organizations/jenkins/integ-test/detail/integ-test/3457/pipeline

  • Index Management

ARM64: https://build.ci.opensearch.org/blue/organizations/jenkins/integ-test/detail/integ-test/3456/pipeline

  • Index Management
    @rishabh6788 ISM fails here for test case: "org.opensearch.indexmanagement.transform.TransformRunnerIT.test continuous transform with wildcard indices" . It is a flaky one. Could you re-run and check it? Thanks!

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Dec 8, 2022

Product/ Version Architecture Description Instance Type Workload Index latency (p50) Index latencyp90 Index latencyp99 Index latencyp100 Index throughputp0 Index throughputp50 Index throughputp100 Ops Count Op Error Count Error Rate Query latencyp50 Query latencyp90 Query latencyp99 Query latencyp100 Query throughputp0 Query throughputp50 Query throughputp100 Ops Count Op Error Count Error Rate CPUp50 CPUp90 CPUp99 CPUp100 Memoryp50 Memoryp90 Memoryp99 Memoryp100 Old Young    
OS 1.3.7 Windows 6672 X64 With Security m5.xlarge nyc_taxis/ 2 warmupIterations/ 3 testIterations 2,473.9 3,862.7 9,315.6 23,941.8 26,997.7 28,175.7 33,575.7 47,197 - - 187.3 200.7 208 226.4 1.74 1.749 1.763 1510 - - 94 95 96 97 54 66 73.62 86 - 2,057,687  
OS 1.3.7 Windows 6672 X64 Without Security m5.xlarge nyc_taxis/ 2 warmupIterations/ 3 testIterations 2,085.4 3,309.1 8,449.3 34,168.1 31,756 33,496.1 38,975 46,829 - - 173 204.1 218.6 260.3 1.742 1.751 1.764 1510 - - 93 95 96 96 54 65 83.06 92 - 1,690,653  
Comparison         15.70% 14.33% 9.30% -42.71% 17.62% 18.88% 16.08%       7.63% -1.69% -5.10% -14.97% 0.11% 0.11% 0.06%                              
-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
OS 1.3.7 Windows 6672 X64 With Security m5.xlarge nyc_taxis/ 2 warmupIterations/ 3 testIterations 2,473.9 3,862.7 9,315.6 23,941.8 26,997.7 28,175.7 33,575.7 47,197 - - 187.3 200.7 208 226.4 1.74 1.749 1.763 1510 - - 94 95 96 97 54 66 73.62 86 - 2,057,687  
OS 2.4.0 Windows 6443 X64 With Security m5.xlarge nyc_taxis/ 2 warmupIterations/ 3 testIterations 2,393.2 3,490 8,011.4 17,680.8 28,401.8 29,648.8 33,415.8 47,249 - - 136.8 139.4 151.2 168.6 1.742 1.75 1.764 1510 - - 95 98 100 100 57 67 84 94 - 1,792,702  
Comparison         3.26% 9.65% 14.00% 26.15% 5.20% 5.23% -0.48%       26.96% 30.54% 27.31% 25.53% 0.11% 0.06% 0.06%                              
-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
OS 1.3.7 Windows 6672 X64 Without Security m5.xlarge nyc_taxis/ 2 warmupIterations/ 3 testIterations 2,085.4 3,309.1 8,449.3 34,168.1 31,756 33,496.1 38,975 46,829 - - 173 204.1 218.6 260.3 1.742 1.751 1.764 1510 - - 93 95 96 96 54 65 83.06 92 - 1,491,492  
OS 2.4.0 Windows 6443 X64 Without Security m5.xlarge nyc_taxis/ 2 warmupIterations/ 3 testIterations 2,214.3 3,190.7 7,772.1 20,755 31,145.8 32,359 36,830.4 46,990 - - 142.8 145.8 165 179.1 1.741 1.75 1.764 1510 - - 95 98 100 100 54 66.2 85 91 - 1,455,204  
Comparison         -6.18% 3.58% 8.01% 39.26% -1.92% -3.39% -5.50%       17.46% 28.56% 24.52% 31.19% -0.06% -0.06% 0.00%                              

@gaiksaya
Copy link
Member

Signature looks good:

% gpg --verify opensearch-dashboards-1.3.7-linux-x64.tar.gz.sig opensearch-dashboards-1.3.7-linux-x64.tar.gz
gpg: Signature made Tue 13 Dec 2022 06:38:19 PM UTC using RSA key ID 542C03B4
gpg: Good signature from "OpenSearch project <[email protected]>"
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: C5B7 4989 65EF D1C2 924B  A9D5 39D3 1987 9310 D3FC
     Subkey fingerprint: 2187 3199 B103 0FCD 49DA  83F8 C2EE 2AF6 542C 03B4
% gpg --verify opensearch-1.3.7-linux-x64.tar.gz.sig opensearch-1.3.7-linux-x64.tar.gz
gpg: Signature made Tue 13 Dec 2022 06:40:59 PM UTC using RSA key ID 542C03B4
gpg: Good signature from "OpenSearch project <[email protected]>"
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: C5B7 4989 65EF D1C2 924B  A9D5 39D3 1987 9310 D3FC
     Subkey fingerprint: 2187 3199 B103 0FCD 49DA  83F8 C2EE 2AF6 542C 03B4

@gaiksaya
Copy link
Member

Native plugins looks good too:

% ./opensearch-plugin install discovery-ec2
-> Installing discovery-ec2
-> Downloading discovery-ec2 from opensearch
[=================================================] 100%
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
@     WARNING: plugin requires additional permissions     @
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
* java.lang.RuntimePermission accessDeclaredMembers
* java.lang.RuntimePermission getClassLoader
* java.lang.reflect.ReflectPermission suppressAccessChecks
* java.net.SocketPermission * connect,resolve
See http://docs.oracle.com/javase/8/docs/technotes/guides/security/permissions.html
for descriptions of what these permissions allow and the associated risks.

Continue with installation? [y/N]y
-> Installed discovery-ec2 with folder name discovery-ec2

@rishabh6788
Copy link
Collaborator

Verified yum installation, everything working as expected.

[root@ip-172-31-24-246 ~]# curl https://localhost:9200/ -ku admin:admin
{
  "name" : "ip-172-31-24-246.eu-west-1.compute.internal",
  "cluster_name" : "opensearch",
  "cluster_uuid" : "nuwxvg-BRnqZhbnDIARWOA",
  "version" : {
    "distribution" : "opensearch",
    "number" : "1.3.7",
    "build_type" : "rpm",
    "build_hash" : "db18a0d5a08b669fb900c00d81462e221f4438ee",
    "build_date" : "2022-12-07T23:00:21.381178Z",
    "build_snapshot" : false,
    "lucene_version" : "8.10.1",
    "minimum_wire_compatibility_version" : "6.8.0",
    "minimum_index_compatibility_version" : "6.0.0-beta1"
  },
  "tagline" : "The OpenSearch Project: https://opensearch.org/"
}

[root@ip-172-31-24-246 ~]# curl https://localhost:9200/_cat/plugins -ku admin:admin
ip-172-31-24-246.eu-west-1.compute.internal opensearch-alerting                  1.3.7.0
ip-172-31-24-246.eu-west-1.compute.internal opensearch-anomaly-detection         1.3.7.0
ip-172-31-24-246.eu-west-1.compute.internal opensearch-asynchronous-search       1.3.7.0
ip-172-31-24-246.eu-west-1.compute.internal opensearch-cross-cluster-replication 1.3.7.0
ip-172-31-24-246.eu-west-1.compute.internal opensearch-index-management          1.3.7.0
ip-172-31-24-246.eu-west-1.compute.internal opensearch-job-scheduler             1.3.7.0
ip-172-31-24-246.eu-west-1.compute.internal opensearch-knn                       1.3.7.0
ip-172-31-24-246.eu-west-1.compute.internal opensearch-ml                        1.3.7.0
ip-172-31-24-246.eu-west-1.compute.internal opensearch-observability             1.3.7.0
ip-172-31-24-246.eu-west-1.compute.internal opensearch-performance-analyzer      1.3.7.0
ip-172-31-24-246.eu-west-1.compute.internal opensearch-reports-scheduler         1.3.7.0
ip-172-31-24-246.eu-west-1.compute.internal opensearch-security                  1.3.7.0
ip-172-31-24-246.eu-west-1.compute.internal opensearch-sql                       1.3.7.0

@rishabh6788
Copy link
Collaborator

1.3.7 released successfully.

@dreamer-89
Copy link
Member

At times, release date changes towards the end of the release. With release notes are created during pre-release stage, there are chances that release date added in release notes is outdated. With 1.3.7 & 2.4.1 we identify that release date changed but the release date in the release notes wasn't. I propose to add one subsection inside Release date to verify that release date is correct in the release notes.

1.3.7 Release Notes: opensearch-project/OpenSearch#5536
2.4.1 Release Notes: opensearch-project/OpenSearch#5549

CC @rishabh6788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants