-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ML Model APIs #733
base: main
Are you sure you want to change the base?
Added ML Model APIs #733
Conversation
Changes AnalysisCommit SHA: 33aab02 API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12437624737/artifacts/2350089724 API Coverage
|
Spec Test Coverage Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. I have some smallish nits. Iterate to green (validation is failing, etc.)
Btw, there's a whole bunch of others missing per #168. They don't all need to be done at the same time. |
Yes, I'm planning to create some small PRs based on the APIs category (model, model groups, connector, agents, etc.) I will also add more missing Model APIs to this PR. |
DCO is missing @nathaliellenaa |
Signed-off-by: dblock <[email protected]> Signed-off-by: Nathalie Jonathan <[email protected]>
…h the tests Signed-off-by: Nathalie Jonathan <[email protected]>
…o models/search.yaml, resolved conflicts and updated CHANGELOG Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: Thomas Farr <[email protected]> Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: dblock <[email protected]> Signed-off-by: Nathalie Jonathan <[email protected]>
…project#732) * Fixed /_search/scroll. Signed-off-by: dblock <[email protected]> * Added tests for GET and POST /_search. Signed-off-by: dblock <[email protected]> * Added a test for GET /_search/pipeline and DELETE /_search/pipeline/{id}. Signed-off-by: dblock <[email protected]> * Added missing _search/point_in_time tests. Signed-off-by: dblock <[email protected]> --------- Signed-off-by: dblock <[email protected]> Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: dblock <[email protected]> Signed-off-by: Nathalie Jonathan <[email protected]>
* Added tests for /_validate/query. Signed-off-by: dblock <[email protected]> * Added retry for opensearch-project#738. Signed-off-by: dblock <[email protected]> --------- Signed-off-by: dblock <[email protected]> Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
37dfa5f
to
78cf49d
Compare
…ata. Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Some nits below.
In tests try to get rid of multiple-paths-detected: false
as much as possible by moving setup into prologues
and teardown into epilogues
. You should only need that set if there's a need to call an unrelated API (e.g. wait on a task) to complete the test. Otherwise chapters
should only have chapters for the API being tested.
…own to epilogues in predict.yaml and load.yaml, updated CHANGELOG format, updated API description, 'model_group_id' ID type, 'version' parameter, and made 'model_format' a type of its own in ml.yaml. Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
…t for deprecated model metadata creation API. Signed-off-by: Nathalie Jonathan <[email protected]>
…pload to create_metadata.yaml, updated CHANGELOG. Signed-off-by: Nathalie Jonathan <[email protected]>
Description
Added missing ML Model APIs.
Issues Resolved
Part of opensearch-project/opensearch-py#867.
ML Model APIs to add
GET /_plugins/_ml/models/{model_id}
POST /_plugins/_ml/models/meta
POST /_plugins/_ml/models/_register_meta
POST /_plugins/_ml/models/_search
POST /_plugins/_ml/models/_undeploy
POST /_plugins/_ml/models/_unload
POST /_plugins/_ml/models/{model_id}/_unload
POST /_plugins/_ml/models/_upload
POST /_plugins/_ml/models/{model_id}/_load
POST /_plugins/_ml/models/{model_id}/_predict
POST /_plugins/_ml/models/{model_id}/chunk/{chunk_number}
POST /_plugins/_ml/models/{model_id}/upload_chunk/{chunk_number}
POST /_plugins/_ml/models/{model_id}/{version}/_register
POST /_plugins/_ml/models/{model_id}/{version}/_upload
PUT /_plugins/_ml/models/{model_id}
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.