Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Release artifact permalink #380

Closed
dblock opened this issue Jul 8, 2024 · 3 comments · Fixed by #397
Closed

[FEATURE] Release artifact permalink #380

dblock opened this issue Jul 8, 2024 · 3 comments · Fixed by #397
Assignees
Labels
enhancement New feature or request

Comments

@dblock
Copy link
Member

dblock commented Jul 8, 2024

Is your feature request related to a problem?

Coming from opensearch-project/opensearch-java#1065 (comment) we are trying to link to an artifact in the main pre-release in https://github.com/opensearch-project/opensearch-api-specification/releases. This repo makes/updates a pre-release with every commit, but doesn't actually make a release, so the pre-release is actually a moving target.

What solution would you like?

Change the release process to produce artifacts that have permalinks. This could be a product of a build with an artifact or a release that can be permalinked, but we likely don't want to make a release with every build. Eventually we will be making releases that match OpenSearch releases with full API coverage.

What alternatives have you considered?

Do nothing, have projects download pre-release artifacts. Wait till we have real releases of API specification, or just start making releases.

@reta
Copy link
Contributor

reta commented Jul 8, 2024

@dblock I will take it, thank you!

@dblock
Copy link
Member Author

dblock commented Jul 10, 2024

I may have accidentally fixed this in #397.

That PR has a couple of drawbacks:

  1. The artifact is uploaded to the build workflow which will eventually expire and be deleted I believe.
  2. The artifact is a zip and doesn't look like that can be changed.

@reta
Copy link
Contributor

reta commented Jul 10, 2024

Thanks @dblock , I think that's a good start, ZIPs could be easily dealt with, please feel free to close this one if not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants