-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Support for wait_for_completion flag in force merge API #152
Comments
@saimedhi What's the right way to bring this in with the new generated code? |
@dblock To add 'wait_for_completion' parameter to the 'forcemerge' API in Python, one approach is through the Python Generator. For a more comprehensive solution, it's best to integrate this parameter into the OpenSearch OpenAPI spec, making it accessible across all language client libraries. |
@saimedhi yes exactly, is there a walkthrough / dev guide of what to add where? |
Yes we have a developer_guide on the api repo: https://github.com/opensearch-project/opensearch-api-specification/blob/main/DEVELOPER_GUIDE.md |
@dblock, @nhtruong please transfer this issue to opensearch-api-specification. I don't have access to do it. |
@saimedhi once this issue is moved there how long it will take for the attribute to be available in python client? |
Hello @navneet1v,
If you're familiar with Smithy, consider contributing. This way, we can ensure our PR gets merged quickly. |
Updated OpenAPI specs in #181 |
Is your feature request related to a problem?
Currently the force merge api in the client waits for force_merge to get completed. But OpenSearch provides a way where if we pass wait_for_completion = true, it gives a task id and poll the task id to see if the force merge is completed or not.
What solution would you like?
Add the support for wait_for_completion flag in force merge api.
What alternatives have you considered?
The only other way is to send Raw HTTP request, but the domain is backed with security creating raw HTTP request is very difficult and not feasible.
Do you have any additional context?
NA
The text was updated successfully, but these errors were encountered: