From 7e1a2333471c3e78dd337a95ce386dfb5757a771 Mon Sep 17 00:00:00 2001
From: kkewwei <kewei.11@bytedance.com>
Date: Wed, 17 Jul 2024 22:30:54 +0800
Subject: [PATCH] set `value` required in constant_keyword field type (#419)

Signed-off-by: kewei.11 <kewei.11@bytedance.com>
Signed-off-by: kkewwei <kewei.11@bytedance.com>
---
 CHANGELOG.md                        |  1 +
 spec/schemas/_common.mapping.yaml   |  3 ++-
 tests/mapping/constant_keyword.yaml | 31 +++++++++++++++++++++++++++++
 3 files changed, 34 insertions(+), 1 deletion(-)
 create mode 100644 tests/mapping/constant_keyword.yaml

diff --git a/CHANGELOG.md b/CHANGELOG.md
index dc960e581..1c87a449f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -83,6 +83,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - Fixed query DSL `match` that supports a field name and value ([#405](https://github.com/opensearch-project/opensearch-api-specification/pull/405)) 
 - Fixed `/_mapping` with `index` in query ([#385](https://github.com/opensearch-project/opensearch-api-specification/pull/385))
 - Fixed duplicate `/_nodes/{node_id}` path ([#416](https://github.com/opensearch-project/opensearch-api-specification/pull/416))
+- Fixed required value for `constant_keyword` field type ([#419](https://github.com/opensearch-project/opensearch-api-specification/pull/419))
 
 ### Security
 
diff --git a/spec/schemas/_common.mapping.yaml b/spec/schemas/_common.mapping.yaml
index 18ef5472f..6c4645abe 100644
--- a/spec/schemas/_common.mapping.yaml
+++ b/spec/schemas/_common.mapping.yaml
@@ -789,13 +789,14 @@ components:
         - type: object
           properties:
             value:
-              type: object
+              type: string
             type:
               type: string
               enum:
                 - constant_keyword
           required:
             - type
+            - value
     FieldAliasProperty:
       allOf:
         - $ref: '#/components/schemas/PropertyBase'
diff --git a/tests/mapping/constant_keyword.yaml b/tests/mapping/constant_keyword.yaml
new file mode 100644
index 000000000..0d209edc5
--- /dev/null
+++ b/tests/mapping/constant_keyword.yaml
@@ -0,0 +1,31 @@
+$schema: ../../json_schemas/test_story.schema.yaml
+
+description: Test constant_keyword field type and retrieving a doc.
+version: '>= 2.14'
+prologues:
+  - path: /movies
+    method: PUT
+    request_body:
+      payload:
+        mappings:
+          properties:
+            genre:
+              type: constant_keyword
+              value: Romantic comedy
+
+epilogues:
+  - path: /movies
+    method: DELETE
+    status: [200, 404]
+chapters:
+  - synopsis: Create a document.
+    path: /{index}/_doc
+    method: POST
+    parameters:
+      index: movies
+    request_body:
+      payload:
+        genre: Romantic comedy
+        year: 1991
+    response:
+      status: 201