-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Implement Image Loading Function for Image Search and CLIP Support #3152
Comments
There is an implemented method in connector level |
Hi, this looks interesting could I be assigned this please? |
Just a heads up, we might need to talk with Security about this with the implementation plan. |
Yeah I was talking to @ylwu-amzn who mentioned that its a security issue to have users download from an external site. We may need to have some sort of design review to see ways to defensively implement this feature. |
Created a ticket with Security to get their advice. Currently we talked to Flow Framework about this and they understood that something like downloading a url within ML-Commons is probably not to be approved to security. |
[Catch All Triage - 1, 2, 3, 4] |
Hey everyone talked with security and they mentioned that this would not likely to pass, it would be better off that the client converts the image to base64 and that we provide validation. What we can do now is start these phases
They also mentioned that in addition to a malicious script its possible they send over a big file over and stall ML-Commons from doing anything else. |
Is your feature request related to a problem?
To support CLIP model and image search, We need to implement a function in the Connector level that can load images from URLs or file path similar to using PIL (Python Imaging Library).
This function should support image search capabilities and be compatible with CLIP (Contrastive Language-Image Pre-training) for advanced image-text understanding
What solution would you like?
Similar to:
with the image loading, we can use the image as model input for clip model to execute prediction
Objectives:
Acceptance Criteria:
Related issue
##3054
The text was updated successfully, but these errors were encountered: