Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Check downstream services before deleting MLModel #3087

Open
yuye-aws opened this issue Oct 10, 2024 · 14 comments
Open

[FEATURE] Check downstream services before deleting MLModel #3087

yuye-aws opened this issue Oct 10, 2024 · 14 comments
Assignees
Labels
enhancement New feature or request

Comments

@yuye-aws
Copy link
Member

yuye-aws commented Oct 10, 2024

Is your feature request related to a problem?
There are several types of downstream services dependent on MLModel. For example, several tools in agent framework (MLModelTool, VectorDBTool and RAGTool) uses MLModel. When deleting the MLModel, we need to first check whether any of the downstream service is using this MLModel.

What solution would you like?
Just like connector, it will return an error if the connector is being used by any model:

1 models are still using this connector, please delete or update the models first: [L05NKJIBVJ7VbbiuxOUx]

What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?
Add any other context or screenshots about the feature request here.

@yuye-aws yuye-aws added enhancement New feature or request untriaged labels Oct 10, 2024
@ylwu-amzn
Copy link
Collaborator

Thanks @yuye-aws, Do you have bandwidth to help on this ?

@ylwu-amzn
Copy link
Collaborator

Assign to you first, let me know if you don't have enough bandwidth.

@yuye-aws
Copy link
Member Author

I'm working on the opensearch-ml-quickstart project in these weeks. @ylwu-amzn You can mark this issue as 2.19.

@yuye-aws
Copy link
Member Author

Plus one use case: Check ConnectorTool agent before deleting the connector

@dhrubo-os
Copy link
Collaborator

Similar issue: #3088

@dhrubo-os
Copy link
Collaborator

@yuye-aws Let's publish your RFC / Design plan so that we can make sure it also aligns with team's bigger plan and also address the issue 3088 I mentioned here. We should also have detailed discussion on this.

@dhrubo-os dhrubo-os moved this from Untriaged to On-deck in ml-commons projects Oct 22, 2024
@yuye-aws
Copy link
Member Author

yuye-aws commented Oct 23, 2024

@dhrubo-os The issue mentions that scan ingest pipelines, search pipelines, any other places where the models may be used in existing resources. Can you at least provide a list of possible places where ml model is being used? For know, the model includes:

  1. ML Model tool
  2. Text embedding processor in pipelines.

Is there any other use cases?

@xinyual
Copy link
Collaborator

xinyual commented Oct 29, 2024

@ylwu-amzn Hi Yaliang, I will take this issue and come up with a RFC ASAP since yuye doesn't have enough bandwidth.

@yuye-aws yuye-aws removed their assignment Oct 29, 2024
@yuye-aws
Copy link
Member Author

@ylwu-amzn Hi Yaliang, I will take this issue and come up with a RFC ASAP since yuye doesn't have enough bandwidth.

Thanks Xinyuan! This issue can be assigned to you, right?

@yuye-aws
Copy link
Member Author

yuye-aws commented Oct 29, 2024

@xinyual Found that RAG tool also has two fields: embedding_model_id and inference_model_id https://opensearch.org/docs/latest/ml-commons-plugin/agents-tools/tools/rag-tool/

@yuye-aws
Copy link
Member Author

Also the conversational agent needs llm.model_id https://opensearch.org/docs/latest/ml-commons-plugin/api/agent-apis/register-agent/

@yuye-aws
Copy link
Member Author

@xinyual xinyual self-assigned this Oct 29, 2024
@yuye-aws
Copy link
Member Author

There is a search response processor named retrieval_augmented_generation using model_id : https://opensearch.org/docs/latest/search-plugins/search-pipelines/rag-processor/

@yuye-aws yuye-aws changed the title [FEATURE] Check MLModelTool agent before deleting MLModel [FEATURE] Check downstream services before deleting MLModel Oct 29, 2024
@xinyual
Copy link
Collaborator

xinyual commented Oct 30, 2024

Raise a RFC for this issue. #3191 @yuye-aws @ylwu-amzn @dhrubo-os Please have a look.

@xinyual xinyual mentioned this issue Nov 11, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: On-deck
Development

No branches or pull requests

4 participants