-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Check downstream services before deleting MLModel #3087
Comments
Thanks @yuye-aws, Do you have bandwidth to help on this ? |
Assign to you first, let me know if you don't have enough bandwidth. |
I'm working on the opensearch-ml-quickstart project in these weeks. @ylwu-amzn You can mark this issue as 2.19. |
Plus one use case: Check ConnectorTool agent before deleting the connector |
Similar issue: #3088 |
@yuye-aws Let's publish your RFC / Design plan so that we can make sure it also aligns with team's bigger plan and also address the issue 3088 I mentioned here. We should also have detailed discussion on this. |
@dhrubo-os The issue mentions that
Is there any other use cases? |
@ylwu-amzn Hi Yaliang, I will take this issue and come up with a RFC ASAP since yuye doesn't have enough bandwidth. |
Thanks Xinyuan! This issue can be assigned to you, right? |
@xinyual Found that RAG tool also has two fields: |
Also the conversational agent needs |
The model controller uses |
There is a search response processor named retrieval_augmented_generation using model_id : https://opensearch.org/docs/latest/search-plugins/search-pipelines/rag-processor/ |
Raise a RFC for this issue. #3191 @yuye-aws @ylwu-amzn @dhrubo-os Please have a look. |
Is your feature request related to a problem?
There are several types of downstream services dependent on MLModel. For example, several tools in agent framework (MLModelTool, VectorDBTool and RAGTool) uses MLModel. When deleting the MLModel, we need to first check whether any of the downstream service is using this MLModel.
What solution would you like?
Just like connector, it will return an error if the connector is being used by any model:
1 models are still using this connector, please delete or update the models first: [L05NKJIBVJ7VbbiuxOUx]
What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.
Do you have any additional context?
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: