Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower the number of required approvers for CRs to 1 #242

Closed
dblock opened this issue Feb 27, 2024 · 4 comments
Closed

Lower the number of required approvers for CRs to 1 #242

dblock opened this issue Feb 27, 2024 · 4 comments
Labels
enhancement Increases software capabilities beyond original client specifications untriaged

Comments

@dblock
Copy link
Member

dblock commented Feb 27, 2024

Is your feature request related to a problem? Please describe.

Currently PRs require 2 PR to be merged. This is slowing us down with only 1-2 active maintainers.

Describe the solution you'd like

Lower the number of approvers to 1.

Additional context

PRs like #237 sitting out here for weeks.
@dblock dblock added the enhancement Increases software capabilities beyond original client specifications label Feb 27, 2024
@dblock
Copy link
Member Author

dblock commented Feb 27, 2024

@asifsmohammed @dlvenable @oeyh?

@dlvenable
Copy link
Member

I agree with this.

@oeyh
Copy link
Collaborator

oeyh commented Feb 27, 2024

I agree.

@dblock
Copy link
Member Author

dblock commented Feb 28, 2024

Looks like the majority of maintainers agree, I lowered the number of approvers required to 1.

@dblock dblock closed this as completed Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Increases software capabilities beyond original client specifications untriaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dlvenable @dblock @oeyh