Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dimension validation for BQ #2269

Open
jmazanec15 opened this issue Nov 12, 2024 · 4 comments
Open

Add dimension validation for BQ #2269

jmazanec15 opened this issue Nov 12, 2024 · 4 comments
Assignees
@gteu @vamshin
Labels
Bug Fixes Changes to a system or product designed to handle a programming bug/glitch good first issue Good for newcomers v2.19.0

Comments

@jmazanec15
Copy link
Member

Description

Right now, BQ requires that input vectors be divisible by 8. It currently fails silently if the dimension is not divisible by 8. We should validate and reject the configuration if a dimension is passed in that is not divisible by 8.
@jmazanec15 jmazanec15 added Bug Fixes Changes to a system or product designed to handle a programming bug/glitch and removed untriaged labels Nov 12, 2024
@navneet1v navneet1v added the good first issue Good for newcomers label Nov 13, 2024
@navneet1v navneet1v moved this to Backlog (Hot) in Vector Search RoadMap Nov 13, 2024
@navneet1v navneet1v moved this from Backlog (Hot) to 2.19.0 in Vector Search RoadMap Nov 13, 2024
@heemin32
Copy link
Collaborator

We can pad zero to make it multiple of 8 instead of rejecting it.

@vamshin
Copy link
Member

vamshin commented Nov 13, 2024

We can pad zero to make it multiple of 8 instead of rejecting it.

makes sense to keep better out-of-box experience.

@gteu
Copy link

gteu commented Dec 2, 2024

Hello, I’m interested in working on this issue. Could I take it?

@vamshin
Copy link
Member

vamshin commented Dec 2, 2024

@gteu assigned to your name. Thanks for your interest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gteu gteu

@vamshin vamshin

Labels
Bug Fixes Changes to a system or product designed to handle a programming bug/glitch good first issue Good for newcomers v2.19.0
Projects
Vector Search RoadMap
Status: 2.19.0
Milestone
No milestone
Development

No branches or pull requests
5 participants
@heemin32 @navneet1v @jmazanec15 @gteu @vamshin