Remove @bbarani as maintainer #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bbarani <[email protected]>
bbarani
requested review from
TheAlgo,
DandyDeveloper,
peterzhuamazon,
prudhvigodithi and
gaiksaya
as code owners
Signed-off-by: bbarani <[email protected]>
gaiksaya
approved these changes
May 28, 2024
peterzhuamazon
approved these changes
May 28, 2024
There was a problem hiding this comment.
Hi @bbarani there are also two more entries in the Chart.yaml of os and osd charts.
We can ignore the test failure after the change tho.
Thanks.
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
|
I will backport to 1.x on this. |
peterzhuamazon
added a commit
to peterzhuamazon/helm-charts
that referenced
this pull request
May 28, 2024
* Remove @bbarani as maintainer Signed-off-by: bbarani <[email protected]> * Fix alignment issue Signed-off-by: bbarani <[email protected]> * Update Chart.yaml Signed-off-by: Peter Zhu <[email protected]> * Update Chart.yaml Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: bbarani <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Co-authored-by: Peter Zhu <[email protected]> Signed-off-by: Peter Zhu <[email protected]>
3 tasks
peterzhuamazon
added a commit
that referenced
this pull request
May 29, 2024
* Remove @bbarani as maintainer * Fix alignment issue * Update Chart.yaml * Update Chart.yaml --------- Signed-off-by: bbarani <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Co-authored-by: Barani <[email protected]>
VILJkid
pushed a commit
to Obmondo/helm-charts-1
that referenced
this pull request
Aug 21, 2024
* Remove @bbarani as maintainer Signed-off-by: bbarani <[email protected]> * Fix alignment issue Signed-off-by: bbarani <[email protected]> * Update Chart.yaml Signed-off-by: Peter Zhu <[email protected]> * Update Chart.yaml Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: bbarani <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Co-authored-by: Peter Zhu <[email protected]> Signed-off-by: VILJkid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove @bbarani as maintainer
Issues Resolved
NA
Check List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.