Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the X-Opaque-Id header #8820

Merged
merged 7 commits into from
Dec 4, 2024

Conversation

andrross
Copy link
Member

A bug was recently identified related to this header that was partly exascerbated by a misuse of the field. We have some documentation related to the Tasks API for this field, but no general guidance on how to use it.

Version

All

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

A [bug][1] was recently identified related to this header that was partly
exascerbated by a misuse of the field. We have some documentation related to the
[Tasks][2] API for this field, but no general guidance on how to use it.

[1]: opensearch-project/OpenSearch#16702
[2]: https://opensearch.org/docs/latest/api-reference/tasks/#attaching-headers-to-tasks

Signed-off-by: Andrew Ross <[email protected]>
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @andrross! A couple of suggestions.

_api-reference/common-parameters.md Outdated Show resolved Hide resolved
_api-reference/common-parameters.md Show resolved Hide resolved
_api-reference/common-parameters.md Outdated Show resolved Hide resolved
andrross and others added 3 commits December 2, 2024 18:28
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolchfa-aws @andrross Please see my changes and let me know if you have any questions. Thanks!

_api-reference/common-parameters.md Outdated Show resolved Hide resolved
_api-reference/common-parameters.md Outdated Show resolved Hide resolved
@kolchfa-aws kolchfa-aws merged commit 1cd69cd into opensearch-project:main Dec 4, 2024
5 checks passed
@kolchfa-aws kolchfa-aws added the backport 2.18 PR: Backport label for 2.18 label Dec 4, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 4, 2024
* Document the `X-Opaque-Id` header

A [bug][1] was recently identified related to this header that was partly
exascerbated by a misuse of the field. We have some documentation related to the
[Tasks][2] API for this field, but no general guidance on how to use it.

[1]: opensearch-project/OpenSearch#16702
[2]: https://opensearch.org/docs/latest/api-reference/tasks/#attaching-headers-to-tasks

Signed-off-by: Andrew Ross <[email protected]>

* Update _api-reference/common-parameters.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>

* Update _api-reference/common-parameters.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>

* Update _api-reference/common-parameters.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>

* Update _api-reference/common-parameters.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>

* Update _api-reference/common-parameters.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>

---------

Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit 1cd69cd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
@andrross andrross deleted the x-opaque-id branch December 4, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.18 PR: Backport label for 2.18
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants