Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Tiered caching in OpenSearch #6300

Closed
1 of 4 tasks
sgup432 opened this issue Jan 30, 2024 · 10 comments · Fixed by #6708 or #7052
Closed
1 of 4 tasks

[DOC] Tiered caching in OpenSearch #6300

sgup432 opened this issue Jan 30, 2024 · 10 comments · Fixed by #6708 or #7052
Assignees
Labels
3 - Done Issue is done/complete v2.14.0
Milestone

Comments

@sgup432
Copy link
Contributor

sgup432 commented Jan 30, 2024

What do you want to do?

  • Request a change to existing documentation
  • Add new documentation
  • Report a technical problem with the documentation
  • Other

Tell us about your request. Provide a summary of the request and all versions that are affected.
We are adding a tiered caching feature where we will extend the existing RequestCache within OpenSearch to include disk cache as well. This is the first milestone.

What other resources are available? Provide links to related issues, POCs, steps for testing, etc.
opensearch-project/OpenSearch#10024
Milestone1 - opensearch-project/OpenSearch#10870

@hdhalter hdhalter added v2.12.0 1 - Backlog - DEV Developer assigned to issue is responsible for creating PR. and removed untriaged labels Jan 30, 2024
@hdhalter hdhalter added this to the v2.12 milestone Jan 30, 2024
@hdhalter
Copy link
Contributor

@sgup432 - Please let me know if this isn't going to make it in 2.12. Thanks!

@bbarani
Copy link
Member

bbarani commented Feb 1, 2024

@sgup432 @kkhatua Can you please confirm if this feature will make it to 2.12.0 release?

@kkhatua kkhatua modified the milestones: v2.12, v2.13 Feb 1, 2024
@kkhatua kkhatua added v2.13.0 and removed v2.12.0 labels Feb 1, 2024
@kkhatua
Copy link
Member

kkhatua commented Feb 1, 2024

Unfortunately no. I've updated the labels. @sgup432 will do for the others as well so as to reflect the revised feature release correctly.

@hdhalter hdhalter added 2 - In progress Issue/PR: The issue or PR is in progress. and removed 1 - Backlog - DEV Developer assigned to issue is responsible for creating PR. labels Mar 18, 2024
@hdhalter hdhalter added 3 - Done Issue is done/complete and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Mar 22, 2024
@kkhatua kkhatua added v2.14.0 and removed 3 - Done Issue is done/complete v2.13.0 labels Apr 22, 2024
@kkhatua kkhatua reopened this Apr 22, 2024
@kkhatua
Copy link
Member

kkhatua commented Apr 22, 2024

Reopened since there is documentation around the Stats API that is missing.

@kkhatua kkhatua added 1 - Backlog - DEV Developer assigned to issue is responsible for creating PR. and removed untriaged labels Apr 22, 2024
@hdhalter hdhalter modified the milestones: v2.13, v2.14 Apr 22, 2024
@hdhalter
Copy link
Contributor

Thanks, @kkhatua. @sgup432 - what is the ETA for producing the doc PR? To meet entrance criteria, the PR must be open and in review by 4/30. Thanks!

@sgup432
Copy link
Contributor Author

sgup432 commented Apr 25, 2024

@hdhalter I will open it by tomorrow. There are few more changes which needs to be merged in 2.14, so waiting on that before I open up a doc PR.

@kiranprakash154
Copy link
Contributor

kiranprakash154 commented Apr 25, 2024

@sgup432 can you also add docs to these settings ?

IndicesRequestCache.INDICES_REQUEST_CACHE_CLEANUP_INTERVAL_SETTING,
IndicesRequestCache.INDICES_REQUEST_CACHE_STALENESS_THRESHOLD_SETTING,

introduced in opensearch-project/OpenSearch#12625 and registered in opensearch-project/OpenSearch#12941 ?

@sgup432
Copy link
Contributor Author

sgup432 commented Apr 26, 2024

Adding this for reminder.
Need to add doc for below setting. If this is disabled, we expect the user to clear the disk cache manually. See opensearch-project/OpenSearch#13373 (comment)

TIERED_SPILLOVER_DISK_CACHE_SETTING

@hdhalter
Copy link
Contributor

Doc PR in progress.

@sgup432
Copy link
Contributor Author

sgup432 commented Apr 29, 2024

@kiranprakash154 Can you pick up the task to add below settings? Or open up a new task for this.

IndicesRequestCache.INDICES_REQUEST_CACHE_CLEANUP_INTERVAL_SETTING,
IndicesRequestCache.INDICES_REQUEST_CACHE_STALENESS_THRESHOLD_SETTING,

We need to see where we can add this. Might require a new sub section.

@hdhalter hdhalter added 2 - In progress Issue/PR: The issue or PR is in progress. and removed 1 - Backlog - DEV Developer assigned to issue is responsible for creating PR. labels Apr 30, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Performance Roadmap May 8, 2024
@hdhalter hdhalter added 3 - Done Issue is done/complete and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete v2.14.0
Projects
Status: Done
5 participants