Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimization] AsyncShardFetch response contains DiscoveryNode which takes GBs of memory #7861

Open
amkhar opened this issue Jun 1, 2023 · 2 comments
Assignees
Labels
bug Something isn't working Cluster Manager distributed framework Performance This is for any performance related enhancements or bugs

Comments

@amkhar
Copy link
Contributor

amkhar commented Jun 1, 2023

Describe the bug
This issue is a subtask to the project #5098 where we are trying to revamp the flow for AsyncShardFetch, as that takes GBs in memory and impacts cluster manager with JVM spikes.

After analyzing the heap dump carefully, we found that DiscoveryNode object is maintained in memory for 1.5 million times though we know these nodes are limited in cluster like 100 only. As part of this optimization we need to understand the reasoning behind it and improve the current objects so DiscoveryNode is maintained in memory for a limited number of times not in order of number of shards etc.

To Reproduce
Step of repro were same as here: #5098 (comment)

Expected behavior
DiscoveryNode objects should be limited and not take memory in GBs.

@amkhar amkhar added bug Something isn't working untriaged labels Jun 1, 2023
@anasalkouz anasalkouz added Performance This is for any performance related enhancements or bugs and removed untriaged labels Jun 6, 2023
@anasalkouz
Copy link
Member

@amkhar are you actively working on fixing this?

@amkhar
Copy link
Contributor Author

amkhar commented Jun 13, 2023

@anasalkouz I've not started working on it, currently working on a revamp approach for #5098

I'll come up with proposal for this after 1-2 weeks. It's in my next priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Cluster Manager distributed framework Performance This is for any performance related enhancements or bugs
Projects
Status: Now(This Quarter)
Development

No branches or pull requests

4 participants