Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [Build Break] buildBwcLinuxTar is expecting 2.7.0 artifact but getting 2.7.1 #7396

Open
peternied opened this issue May 3, 2023 · 7 comments
Open

[BUG] [Build Break] buildBwcLinuxTar is expecting 2.7.0 artifact but getting 2.7.1 #7396

peternied opened this issue May 3, 2023 · 7 comments
Labels
bug Something isn't working Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. flaky-test Random test failure that succeeds on second run

Comments

@peternied
Copy link
Member

Describe the bug
The gradle task:distribution:bwc:staged:buildBwcLinuxTar fails on the Jenkins build and locally. See the error message

> Task :distribution:bwc:staged:checkoutBwcBranch
Performing checkout of opensearch-project/2.7...
Checkout hash for :distribution:bwc:staged is f28d1898ee227461c438f054a02e7701a3564393

...

* What went wrong:
Execution failed for task ':distribution:bwc:staged:buildBwcLinuxTar'.
> Building 2.7.0 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/staged/build/bwc/checkout-2.7/distribution/archives/linux-tar/build/distributions/opensearch-min-2.7.0-SNAPSHOT-linux-x64.tar.gz

To Reproduce
Run ./gradlew :distribution:bwc:staged:buildBwcLinuxTar

Additional context
@peternied peternied added bug Something isn't working untriaged flaky-test Random test failure that succeeds on second run labels May 3, 2023
@peternied
Copy link
Member Author

I've added the flaky test flag because it seems like this test is not reliable due to changes unrelated to the current pull request.

@peternied peternied changed the title [BUG] [Build Break] checkoutBwcBranch is expecting 2.7.0 artifact but getting 2.7.1 [BUG] [Build Break] buildBwcLinuxTar is expecting 2.7.0 artifact but getting 2.7.1 May 3, 2023
@kotwanikunal
Copy link
Member

@peternied This was fixed as a part of #7379
Can you please try and rebase your branch?

@kotwanikunal
Copy link
Member

@peternied Can you please verify the fix and close out the issue?

@peternied peternied mentioned this issue May 3, 2023
Closed
6 tasks
@peternied
Copy link
Member Author

I've created #7398 that fixes the cause of this flaky test. After that pull request is merged / closed, I'll resolve this issue.

peternied added a commit to peternied/OpenSearch-1 that referenced this issue May 5, 2023
@peternied
Rewrite version update GHA to commit and push
9b53b7e 
This change alters the version workflow to create a new issue, then
create several commits linked back to that issue and finally close the
issue when all commits are completed for tracability of version updates.

Background

As version updates have different propigation speeds depending on pull
request reviews, consistant CI in many branches, and an careful order of
execution this would cause failures outside the scope of changes that
would block changes into main and other branches.

This change removes the use of pull requests and the standard ci gates.
To ensure that the changes operate consistantly created a GitHub Action
to manage the file modification peternied/opensearch-core-version-updater

See an example of this workflows results with #66

Related issues
- Resolves opensearch-project#7411
- Related Discussion opensearch-project#7398
- Resolves opensearch-project#7396

Signed-off-by: Peter Nied <[email protected]>
@peternied peternied mentioned this issue May 5, 2023
Closed
11 tasks
@dbwiddis dbwiddis mentioned this issue Jun 21, 2023
Merged
6 tasks
@kohinoor98 kohinoor98 mentioned this issue Nov 14, 2023
Closed
7 tasks
@peternied
Copy link
Member Author

Impacted PR, jenkins gradle check logs.

@peternied peternied mentioned this issue Dec 7, 2023
Merged
8 tasks
@kotwanikunal kotwanikunal mentioned this issue Jan 18, 2024
Merged
8 tasks
@kotwanikunal kotwanikunal removed their assignment Jan 22, 2024
@peternied
Copy link
Member Author

peternied commented Feb 21, 2024 •
edited
Loading

@andrross While #11926 did reference this issue it didn't fix the underlying problem - if a new version is published existing pull requests have to rebase/merge or they will fail. Was there another PR or test change that addressed this?

@peternied peternied reopened this Feb 21, 2024
@andrross
Copy link
Member

if a new version is published existing pull requests have to rebase/merge or they will fail. Was there another PR or test change that addressed this?

No, that behavior is still present.

@andrross andrross added the Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. label Mar 12, 2024
@kiranprakash154 kiranprakash154 mentioned this issue Apr 3, 2024
Merged
8 tasks
@andrross andrross removed the untriaged label Apr 4, 2024
@peternied peternied mentioned this issue May 15, 2024
Merged
9 tasks
@kiranprakash154 kiranprakash154 mentioned this issue May 17, 2024
Merged
9 tasks
@chishui chishui mentioned this issue Aug 2, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. flaky-test Random test failure that succeeds on second run
Projects
None yet
Milestone
No milestone
4 participants
@peternied @andrross @dbwiddis @kotwanikunal