Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exists queries on nested flat_object fields throws exception #16803

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Dec 8, 2024

Description

[Describe what this change achieves]

Related Issues

Resolves #16795

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Dec 8, 2024

❌ Gradle check result for 5763a44: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the fix_bug_flat_object branch from 5763a44 to 7d38155 Compare December 8, 2024 20:25
Copy link
Contributor

github-actions bot commented Dec 8, 2024

✅ Gradle check result for 7d38155: SUCCESS

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.01%. Comparing base (42dc22e) to head (7d38155).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...opensearch/index/mapper/FlatObjectFieldMapper.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16803      +/-   ##
============================================
- Coverage     72.05%   72.01%   -0.04%     
+ Complexity    65183    65157      -26     
============================================
  Files          5318     5318              
  Lines        303993   303996       +3     
  Branches      43990    43992       +2     
============================================
- Hits         219028   218923     -105     
- Misses        67046    67111      +65     
- Partials      17919    17962      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Search Search query, autocomplete ...etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] exists queries on nested flat_object fields throw a string_index_out_of_bounds_exception
1 participant