Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Concurrent Segment Search] Concurrent search index setting default value is false but is not evaluated when not explicitly set #12594

Closed
jed326 opened this issue Mar 11, 2024 · 1 comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Performance

Comments

@jed326
Copy link
Collaborator

jed326 commented Mar 11, 2024

Is your feature request related to a problem? Please describe

The concurrent segment search index setting has a default value of false, however the setting itself is not used unless it is explicitly set. This can be confusing as checking an index setting with the include_defaults flag will show the concurrent search index setting as false even though concurrent search may still be enabled for a given index depending on the cluster setting.

Describe the solution you'd like

Using the include_defaults flag when getting index settings should give a clearer picture of whether or not concurrent segment search is enabled.

Related component

Search:Performance

Describe alternatives you've considered

No response

Additional context

No response

@jed326
Copy link
Collaborator Author

jed326 commented Jun 25, 2024

Going to close this out as I don't think it makes sense for the include_defaults value to show anything other than the default specified in code.

@jed326 jed326 closed this as completed Jun 25, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Concurrent Search Jun 25, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Search Project Board Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Performance
Projects
Status: Done
Archived in project
Development

No branches or pull requests

1 participant