Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] <Decouple the use of CryptoPlugin and CryptoKeyProviderPlugin> #12472

Open
asonje opened this issue Feb 26, 2024 · 3 comments
Labels
discuss Issues intended to help drive brainstorming and decision making enhancement Enhancement or improvement to existing feature or request help wanted Extra attention is needed Plugins

Comments

@asonje
Copy link

asonje commented Feb 26, 2024

Is your feature request related to a problem? Please describe

crypto-kms plugin is a CryptoKeyProviderPlugin which currently fails to load on server startup even after being successfully installed. This happens because the CryptoHandlerRegistry would not load a CryptoKeyProviderPlugin without a CryptoPlugin present even though no CryptoPlugin implementation exists yet.

Describe the solution you'd like

The use of a CryptoKeyProviderPlugin should be decoupled from a CryptoPlugin; at least Opensearch should be able to load one plugin without the other. This can be easily achieved by modifying the logic in CryptoHandlerRegistry constructor that disallows this

Related component

Plugins

Describe alternatives you've considered

No response

Additional context

This proposed plugin (#12451, #12902) relies on a CryptoKeyProviderPlugin for managing keys and will not work without this feature

@asonje asonje added enhancement Enhancement or improvement to existing feature or request untriaged labels Feb 26, 2024
@andrross
Copy link
Member

/cc @vikasvb90

@vikasvb90
Copy link
Contributor

Thanks for notifying @andrross!
@asonje Do you see any use of key provider plugin without CryptoPlugin? If yes, then we can remove the strict check of CryptoPlugin to exist.

@peternied peternied added help wanted Extra attention is needed discuss Issues intended to help drive brainstorming and decision making and removed untriaged labels Feb 28, 2024
@peternied
Copy link
Member

[Triage - attendees 1 2 3 4 5]
@asonje Thanks for filing - there might be other ways we can restructure this plugin to make its interfaces cleaner that would be worthwhile to consider during this effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issues intended to help drive brainstorming and decision making enhancement Enhancement or improvement to existing feature or request help wanted Extra attention is needed Plugins
Projects
None yet
Development

No branches or pull requests

4 participants