Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Non-Dynamic S3 Configuration in Single-Node Opensearch Setup Fails to Restart in GitLab CI/CD #11302

Closed
IvanZenger opened this issue Nov 22, 2023 · 5 comments
Labels
bug Something isn't working feedback needed Issue or PR needs feedback Plugins Storage Issues and PRs relating to data and metadata storage

Comments

@IvanZenger
Copy link

Describe the bug
I am setting up Opensearch as a Single-Node within a GitLab CI/CD Service and need to configure the following: s3.client.backup.endpoint: s3-endpoint.foo.ch and s3.client.backup.region: foobaar.

The problem is that these configurations are not dynamic, requiring a restart of the node. However, such a restart is not feasible within a GitLab Service.

Using environment variables (ENV) is not a solution in this case, as the opensearch-docker-entrypoint.sh script (see opensearch-project/opensearch-build) only processes two-level configurations.

To Reproduce
Steps to reproduce the behavior:

  1. Start GitLab Job (Simplified):
integration-test:
  stage: pre-test
  variables:
    FF_NETWORK_PER_BUILD: 1
    OPENSEARCH_JAVA_OPTS: "-Xms512m -Xmx512m"
    CI_DEBUG_SERVICES: "true"
  services:
    - name: opensearchproject/opensearch:2.9.0
      alias: opensearch
      entrypoint: ["bash", "-c", "env 's3.client.backup.endpoint=s3-endpint.foo.ch' 's3.client.backup.region=foobar' 'discovery.type=single-node' 'cluster.name=opensearch' ./opensearch-docker-entrypoint.sh"]
  script:
    - > #https://gitlab.com/gitlab-org/gitlab/-/issues/24197
      until curl -o /dev/null -sSf -w '%{http_code}' https://opensearch:9200/_cat/health --insecure -u "admin:admin" | grep -q '200'; do
        echo 'Waiting for OpenSearch to be ready...'; sleep 10;
      done

Or alternatively, a corresponding docker run command

Expected behavior
The configuration I have set as an environment variable (ENV) is being applied as settings (like discovery.type=single-node).

Plugins
repository-s3

Host/Environment (please complete the following information):

  • OS: [RHEL8]
  • Opensearch Version 22.9.0
@IvanZenger IvanZenger added bug Something isn't working untriaged labels Nov 22, 2023
@IvanZenger IvanZenger changed the title [BUG] [BUG]: Non-Dynamic S3 Configuration in Single-Node Opensearch Setup Fails to Restart in GitLab CI/CD Nov 22, 2023
@mch2 mch2 added Plugins Storage Issues and PRs relating to data and metadata storage labels Dec 8, 2023
@peternied
Copy link
Member

[Triage - attendees 1 2 3 4]
@IvanZenger Thanks for filing

@peternied
Copy link
Member

@reta Did you have thoughts about this issue?

@gbbafna
Copy link
Collaborator

gbbafna commented Apr 4, 2024

@IvanZenger , have you tried out reloadable repository introduced in 2.11 ? Please refer to this changes .

@ashking94 ashking94 added the feedback needed Issue or PR needs feedback label Apr 18, 2024
@ashking94
Copy link
Member

[Triage - attendees 1 2 3 4 5 6 7 8 9 10 11 12]
We are closing this issue. Please do reopen if you have any questions.

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Storage Project Board Apr 18, 2024
@peternied
Copy link
Member

peternied commented Apr 18, 2024

@ashking94 Could you include why this issue was closed? There are templates [1] for typical responses you can reuse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feedback needed Issue or PR needs feedback Plugins Storage Issues and PRs relating to data and metadata storage
Projects
Status: ✅ Done
Development

No branches or pull requests

5 participants