Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Segment Replication - Resize API check can incorrectly pass when determining replica staleness. #10342

Open
mch2 opened this issue Oct 3, 2023 · 0 comments
Labels
bug Something isn't working Indexing:Replication Issues and PRs related to core replication framework eg segrep

Comments

@mch2
Copy link
Member

mch2 commented Oct 3, 2023

Describe the bug
Today with SegRep we add a check during resize to ensure replicas are caught up before continuing with these operations.

To fix #10123 we need to flip how these metrics are computed by making staleness computations on the replica. This means that these APIs are subject to a delay where replicas must first receive the latest primary checkpoint.

To give an accurate picture of staleness, we need to fetch the on-reader SegmentInfos version from each shard and compare it with its primary. I'm thinking we create a separate transport level API to do this and report back because the cat segRep API is a lot heavier and is intended to give an at a glance view.

Expected behavior
The check should consider the SegmentInfos version instead of an estimated bytes computation.

@mch2 mch2 added bug Something isn't working untriaged labels Oct 3, 2023
@anasalkouz anasalkouz added the Indexing:Replication Issues and PRs related to core replication framework eg segrep label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Indexing:Replication Issues and PRs related to core replication framework eg segrep
Projects
None yet
Development

No branches or pull requests

2 participants