Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tiered caching] [Milestone 1] Enable serialization for IndicesRequest cache key #10308

Closed
sgup432 opened this issue Oct 2, 2023 · 0 comments · Fixed by #10275
Closed

[Tiered caching] [Milestone 1] Enable serialization for IndicesRequest cache key #10308

sgup432 opened this issue Oct 2, 2023 · 0 comments · Fixed by #10275
Labels
enhancement Enhancement or improvement to existing feature or request Search:Performance Search Search query, autocomplete ...etc

Comments

@sgup432
Copy link
Contributor

sgup432 commented Oct 2, 2023

Is your feature request related to a problem? Please describe.
As of now, request cache is a composite key comprising shardId, query object and IndexReader.CacheKey. We need to make it serializable for it to store to disk as part of tiered caching. CacheKey is tightly coupled with lucene which makes it tricky. We essentially need to wrap CacheKey in OpenSearch to be able to solve this.

Refer main issue for more details - #10024
and #10870

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@sgup432 sgup432 added enhancement Enhancement or improvement to existing feature or request untriaged labels Oct 2, 2023
@sgup432 sgup432 moved this to In-Review in Performance Roadmap Nov 3, 2023
@ankitkala ankitkala added Search Search query, autocomplete ...etc and removed Other labels Dec 17, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Search Project Board Jan 11, 2024
@github-project-automation github-project-automation bot moved this from In-Review to Done in Performance Roadmap Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Performance Search Search query, autocomplete ...etc
Projects
Status: Done
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants