Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove head 10 for PPL default query to unblock cypress test failures #8827

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Remove head 10 for PPL default query to unblock cypress test failures #8827

merged 2 commits into from
Nov 8, 2024

Conversation

abbyhu2000
Copy link
Member

@abbyhu2000 abbyhu2000 commented Nov 7, 2024 •
edited
Loading

Description

Remove head 10 for PPL default query to unblock cypress test failures

Issues Resolved

Screenshot

Testing the changes

Changelog

  • test: Remove head 10 for PPL default query to unblock cypress test failures

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

opensearch-changeset-bot bot added a commit to abbyhu2000/OpenSearch-Dashboards that referenced this pull request Nov 7, 2024
@opensearch-changeset-bot
Changeset file for PR opensearch-project#8827 created/updated
71f1f29
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.88%. Comparing base (af4943d) to head (f388235).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8827      +/-   ##
==========================================
+ Coverage   60.80%   60.88%   +0.08%     
==========================================
  Files        3798     3799       +1     
  Lines       90738    90761      +23     
  Branches    14292    14294       +2     
==========================================
+ Hits        55170    55260      +90     
+ Misses      32065    31992      -73     
- Partials     3503     3509       +6
Flag Coverage Δ
Linux_1 29.04% <ø> (-0.01%) ⬇️
Linux_2 56.39% <ø> (ø)
Linux_3 37.81% <ø> (+0.15%) ⬆️
Linux_4 29.87% <ø> (-0.01%) ⬇️
Windows_1 29.08% <ø> (+0.01%) ⬆️
Windows_2 56.34% <ø> (ø)
Windows_3 37.81% <ø> (+0.15%) ⬆️
Windows_4 29.87% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ananzh
ananzh previously approved these changes Nov 7, 2024
View reviewed changes
sejli
sejli previously approved these changes Nov 7, 2024
View reviewed changes
@kavilla
Copy link
Member

kavilla commented Nov 7, 2024

feat: Remove head 10 for PPL default query

nit: i dont think it's a feature to remove something.

to unblock cypress test failures

might be worth to mention the underlying issue why it's blocking. in this case, PPL automatically appends the stats call when doing aggregations. it is appending it after the head 10 now which causes the query to not succeed.

kavilla
kavilla previously approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty. just comments on the changelog section but not seeing the changelog so just as long the merge is more insightful

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

❌ Invalid Prefix

Invalid description prefix. Found "Remove head 10 for PPL default query to unblock cypress test failures". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test".

@opensearch-changeset-bot opensearch-changeset-bot bot dismissed stale reviews from kavilla, sejli, and ananzh via f388235 November 7, 2024 23:47
@abbyhu2000 abbyhu2000 merged commit aa60870 into opensearch-project:main Nov 8, 2024
68 of 70 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 8, 2024
@github-actions @opensearch-changeset-bot
Remove head 10 for PPL default query to unblock cypress test failur…
0b91933 
…es (#8827)

* remove head 10 for PPL to unblock cypress test failures

Signed-off-by: abbyhu2000 <[email protected]>

* Changeset file for PR #8827 created/updated

---------

Signed-off-by: abbyhu2000 <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit aa60870)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 8, 2024
Merged
abbyhu2000 pushed a commit that referenced this pull request Nov 8, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
Remove head 10 for PPL default query to unblock cypress test failur…
b9ea335 
…es (#8827) (#8831)

* remove head 10 for PPL to unblock cypress test failures



* Changeset file for PR #8827 created/updated

---------



(cherry picked from commit aa60870)

Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
abbyhu2000 added a commit to abbyhu2000/OpenSearch-Dashboards that referenced this pull request Nov 25, 2024
@abbyhu2000
Revert "Remove head 10 for PPL default query to unblock cypress tes…
8684524 
…t failures (opensearch-project#8827)"

This reverts commit aa60870.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sejli sejli sejli approved these changes

@kavilla kavilla kavilla approved these changes

@ananzh ananzh ananzh left review comments

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
backport 2.x discover for discover reinvent discover-next distinguished-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abbyhu2000 @kavilla @sejli @ananzh