Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Filters stored in saved search are not loaded #8339

Closed
msoler8785 opened this issue Sep 25, 2024 · 17 comments
Closed

[BUG] Filters stored in saved search are not loaded #8339

msoler8785 opened this issue Sep 25, 2024 · 17 comments
Assignees
Labels
bug Something isn't working

Comments

@msoler8785
Copy link

Describe the bug

After upgrading to 2.17 none of my saved searches load the previously saved filters. When I inspect the object, the filters are still stored there, but do not load. I do not see any errors in the browser console. I have cleared browser cache and tried the latest Chrome, Edge, and Firefox browsers.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Discover
  2. Add a filter
  3. Save a new search
  4. Click "New" search
  5. Remove any filters from the page
  6. Click "Open"
  7. Open the search that was just saved
  8. Observe all the filters are missing.

Expected behavior
When a search is saved, all of the configured filters are saved along with it.

OpenSearch Version
2.17

Dashboards Version
2.17

Plugins
kibana-enhanced-table

Screenshots
N/A

Host/Environment (please complete the following information):

  • OS: Windows 11
  • Microsoft Edge: 129.0.2792.52 (Official build) (64-bit)
  • Firefox 130.0.1 (64-bit)
  • Chrome 129.0.6668.70 (Official Build) (64-bit) (cohort: M129 Rollout)

Additional context

Potentially related issues:
#7677
#8338

@msoler8785 msoler8785 added bug Something isn't working untriaged labels Sep 25, 2024
@Psych0meter
Copy link

Same problem here.
I also tried to restore an old version of a saved search through saved objects, filters are still not displayed (but seems to works)

Host/Environment (please complete the following information):

  • OpenSearch and Dashboards 2.17.0
  • OS: MacOS 15.0
  • Chrome Version 129.0.6668.60 (Official Build) (arm64)

@jasonrojas
Copy link

I am seeing this as well on 2.17.0 - Viewing the document in the .kibana index shows that it is saved with the query filters in place. Tested on a 2.16.0 opensearch-dashboards pointed at the same cluster and did not see any issues.

@StefanStroebel
Copy link

Also experienceing the same. TO add to this when exporting the saved object the filter is saved in the object.

@cinhtau
Copy link

cinhtau commented Oct 4, 2024

Thanks a lot for filing, this is quite severe. Already the 2nd major issue for my users after the date wrap disaster #8441. My user base is growingly frustrated with the UI changes or experience.

I exported the saved object search, re-applied the filters in Dashboards v2.17 and save it.
I opened a private window, load the saved search and all filters vanished or not applied again. This make the product unusable. With more than 1000 saved searches, we have to try downgrade to 2.16 or use Dashboards v2.16 with OpenSearch v2.17.

@cinhtau
Copy link

cinhtau commented Oct 4, 2024

Just tested the usage of Dashboards v2.16 with OpenSearch v2.17. It works, filters in saved search were properly applied.

@StefanStroebel
Copy link

StefanStroebel commented Oct 4, 2024

We also downgraded Dashboards to v2.16 on Opensearch 2.17 code base.

@LDrago27
Copy link
Collaborator

LDrago27 commented Oct 4, 2024

Thanks for bringing this up. The above PR should fix the issues with filters.

@LDrago27 LDrago27 removed the untriaged label Oct 4, 2024
@LDrago27 LDrago27 linked a pull request Oct 4, 2024 that will close this issue
7 tasks
@nerijus
Copy link

nerijus commented Oct 7, 2024

Thanks for bringing this up. The above PR should fix the issues with filters.

Could you please backport the PR to 2.x, so that we can apply it and build the packages?

@LDrago27
Copy link
Collaborator

LDrago27 commented Oct 7, 2024

Thanks for bringing this up. The above PR should fix the issues with filters.

Could you please backport the PR to 2.x, so that we can apply it and build the packages?

Sure.

@cinhtau
Copy link

cinhtau commented Nov 12, 2024

I tested OpenSearch Dashboards 2.18.0 with OpenSearch 2.17.0. It seems to be gone.

I repackaged it as 2.17.9 for my experiment. Going to let my users work with it for a week before fully upgrading to 2.18.

@LDrago27
Copy link
Collaborator

Hi folks, The fix for this issue has been adressed in this PR #8689 which has already been merged into main. Using

@ohenr
Copy link

ohenr commented Nov 13, 2024

can we have a new build for the Docker tag 2.17.1 then?

@iliuta
Copy link

iliuta commented Nov 19, 2024

Same here, this is annoying, especially because the 2.17 is on AWS already ...

@joneswac
Copy link

joneswac commented Dec 3, 2024

Is this in 2.17.1? We're still seeing the bug in that version.

@msoler8785
Copy link
Author

@joneswac
Yeah, I think that version is affected. I upgraded to 2.18.0 and it works again.

@fire2
Copy link

fire2 commented Dec 5, 2024

Are there any plans to backport this to 2.17.x? That's the latest version available on AWS...

@iliuta
Copy link

iliuta commented Dec 5, 2024

Are there any plans to backport this to 2.17.x? That's the latest version available on AWS...

I asked AWS support and they told me that they are sorry, but the fix will come with the next version (2.18 or so). (We used to be a big customer of theirs).

I've been waiting for a couple of months to migrate from 2.15 to 2.17. And now, 2.17 is bugged. We'll have to wait for a few months as well? Do they even have non regression tests of the software they provide to the customers?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.