[GitHub Request] Add necessary secrets to publish Remote Metadata Client Snapshots

[dbwiddis]

What is the type of request?

Secret Update

Details of the request

Please enable the necessary secrets to https://github.com/opensearch-project/opensearch-remote-metadata-sdk to enable the snapshot publication workflow:

• Publish snapshots to Central Repository opensearch-remote-metadata-sdk#12

This appears to be PUBLISH_SNAPSHOTS_ROLE required by this step:

      - uses: aws-actions/[email protected]
        with:
          role-to-assume: ${{ secrets.PUBLISH_SNAPSHOTS_ROLE }}
          aws-region: us-east-1

Additional information to support your request

The following artifacts will be published:

➜  opensearch-remote-metadata-sdk git:(maven-publish) tree -L 3 ~/.m2/repository/org/opensearch
/Users/widdisd/.m2/repository/org/opensearch
├── opensearch-remote-metadata-sdk
│   ├── 3.0.0-SNAPSHOT
│   │   ├── maven-metadata-local.xml
│   │   ├── opensearch-remote-metadata-sdk-3.0.0-SNAPSHOT-javadoc.jar
│   │   ├── opensearch-remote-metadata-sdk-3.0.0-SNAPSHOT-sources.jar
│   │   ├── opensearch-remote-metadata-sdk-3.0.0-SNAPSHOT-test-fixtures.jar
│   │   ├── opensearch-remote-metadata-sdk-3.0.0-SNAPSHOT.jar
│   │   ├── opensearch-remote-metadata-sdk-3.0.0-SNAPSHOT.module
│   │   └── opensearch-remote-metadata-sdk-3.0.0-SNAPSHOT.pom
│   └── maven-metadata-local.xml
├── opensearch-remote-metadata-sdk-aos-client
│   ├── 3.0.0-SNAPSHOT
│   │   ├── maven-metadata-local.xml
│   │   ├── opensearch-remote-metadata-sdk-aos-client-3.0.0-SNAPSHOT-javadoc.jar
│   │   ├── opensearch-remote-metadata-sdk-aos-client-3.0.0-SNAPSHOT-sources.jar
│   │   ├── opensearch-remote-metadata-sdk-aos-client-3.0.0-SNAPSHOT.jar
│   │   ├── opensearch-remote-metadata-sdk-aos-client-3.0.0-SNAPSHOT.module
│   │   └── opensearch-remote-metadata-sdk-aos-client-3.0.0-SNAPSHOT.pom
│   └── maven-metadata-local.xml
├── opensearch-remote-metadata-sdk-ddb-client
│   ├── 3.0.0-SNAPSHOT
│   │   ├── maven-metadata-local.xml
│   │   ├── opensearch-remote-metadata-sdk-ddb-client-3.0.0-SNAPSHOT-javadoc.jar
│   │   ├── opensearch-remote-metadata-sdk-ddb-client-3.0.0-SNAPSHOT-sources.jar
│   │   ├── opensearch-remote-metadata-sdk-ddb-client-3.0.0-SNAPSHOT.jar
│   │   ├── opensearch-remote-metadata-sdk-ddb-client-3.0.0-SNAPSHOT.module
│   │   └── opensearch-remote-metadata-sdk-ddb-client-3.0.0-SNAPSHOT.pom
│   └── maven-metadata-local.xml
└── opensearch-remote-metadata-sdk-remote-client
    ├── 3.0.0-SNAPSHOT
    │   ├── maven-metadata-local.xml
    │   ├── opensearch-remote-metadata-sdk-remote-client-3.0.0-SNAPSHOT-javadoc.jar
    │   ├── opensearch-remote-metadata-sdk-remote-client-3.0.0-SNAPSHOT-sources.jar
    │   ├── opensearch-remote-metadata-sdk-remote-client-3.0.0-SNAPSHOT.jar
    │   ├── opensearch-remote-metadata-sdk-remote-client-3.0.0-SNAPSHOT.module
    │   └── opensearch-remote-metadata-sdk-remote-client-3.0.0-SNAPSHOT.pom
    └── maven-metadata-local.xml

When does this request need to be completed?

ASAP. This publication is currently blocking these two PRs, targeted for 2.19.0

• Implement multi tenancy in Flow Framework flow-framework#980
• [DRAFT] Primary setup for Multi-tenancy ml-commons#3307

Notes

Track the progress of your request here: https://github.com/orgs/opensearch-project/projects/208/views/33.
Member of @opensearch-project/admin will take a look at the request soon.
Thanks!

[peterzhuamazon]

Pending this until the repo is public.

[dbwiddis]

Hey @peterzhuamazon not sure what happened here.

• repo was initially created public, I forked and set up triangle workflow, submitted PRs etc
• now that you flipped the repo private pending the "make a repo public" checklist I can't seem to commit to it at all
  • I can't fork it (I already forked it so I could rename my copy but it still shows as the same repo)
  • it shows as upstream but I can't submit a PR to it (my PR from my fork just points to my fork's main, not upstream)
  • I can't push to main on upstream (no errors but it doesn't seem to go anywhere)

I could probably edit files in place on the main repo but that seems wrong.

I might be able to delete my fork and re-fork it (possibly to a private fork?) which might fix things, but I don't really want to blow up a whole repo for just an admin flip-it-private switch.

Any thoughts here?

[dbwiddis]

• I can't fork it (I already forked it so I could rename my copy but it still shows as the same repo)

Deleting my fork and re-forking did the trick. (Although closed an open PR when the source branch/repo was deleted. 😦)

[dbwiddis]

I'm 99.9% convinced that flipping that repo private broke something with GitHub Actions.

• See https://github.com/opensearch-project/opensearch-remote-metadata-sdk/actions
• runs on linux and windows don't complete, they just hang (but work just fine on macOS)
• A PR that had completely passing CI on the PR failed on push to main when it was pushed after the switch
• no changes were made to GHA that should have changed anything; I did add one change that may have impacted things, but I reverted it and the failure still occurs

Possibilities:

• some permissions needed for private repo access to other actions outside the org?
• some token/quota limit on private repos?

[peterzhuamazon]

Replaced by opensearch-project/opensearch-remote-metadata-sdk#17

[peterzhuamazon]

Working on make the repo public properly.

[peterzhuamazon]

Repo public, will check on the maven snapshot next week.

[dbwiddis]

Thanks for the help! Snapshot workflow currently failing on fetching the creds, let's give it the weekend to see if it just needs time to replicate something somewhere...