Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add BuildTool marker to Maven Wrapper and pom.xml files #721

Closed

Conversation

timtebeek
Copy link
Contributor

What's your motivation?

Fixes #649

We saw the plugin over report changes made to files in

@timtebeek timtebeek self-assigned this Jan 24, 2024
@timtebeek timtebeek marked this pull request as ready for review January 24, 2024 19:41
@timtebeek timtebeek added the bug Something isn't working label Jan 24, 2024
@timtebeek timtebeek requested a review from shanman190 January 24, 2024 19:41
@shanman190
Copy link
Contributor

shanman190 commented Jan 24, 2024

I'm not sure on this one at the moment given over on the Gradle side, we've been messing with the GradleProject marker which is equivalent to the MavenResolutionResult marker on the Maven side. I think doing this has much more significant outcomes than meets the eye.

We'll chat more on Slack though.

@timtebeek timtebeek closed this Jan 24, 2024
@timtebeek timtebeek deleted the only-add-buildtool-marker-to-pom-and-wrapper-files branch January 24, 2024 20:41
@timtebeek
Copy link
Contributor Author

You're right, this needs some more thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Incompatibility with Maven Polyglot leads to ParseError
2 participants