Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Investigate why the feedback e-mails do not come to the set mail. #1752

Open
8 of 9 tasks
abaranowska1 opened this issue Feb 22, 2021 · 6 comments
Open
8 of 9 tasks
Assignees
Labels
bug Something isn't working estimated Story Points: 2

Comments

@abaranowska1
Copy link

abaranowska1 commented Feb 22, 2021

Bug description
According to #1133 after sending a feedback email it should be delivered. During regression, I asked @johnhbenetech and he confirmed that he didn't get an email. Please investigate why.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Feedback page in the header
  2. Send a message.

Dev Signoffs

  • Unit test added for the core business features at the minimum
  • Code review passed
  • CI passed successfully
  • CodeQL scan for vulnerabilities in code has passed
  • Docker images have been built and deployed to the dev server

QA Signoffs

  • Passes Acceptance Criteria
  • All bug reports fixed/merged/tested
  • Regression test cases cycle updated if needed

Product Signoff

  • Approved for release
@abaranowska1 abaranowska1 added the bug Something isn't working label Feb 22, 2021
@jkondrat jkondrat self-assigned this Feb 23, 2021
@jkondrat
Copy link
Collaborator

jkondrat commented Feb 23, 2021

@johnhbenetech it seems that it's no longer allowed to set 'from' address when sending out emails with Sendgrid (it still returns code 202, the error message can probably be found in the Sengrid app). I will try setting 'Reply-to' header, if that doesn't work perhaps we can include something like 'Please reply to [email protected]' in the body of the message?

@jkondrat
Copy link
Collaborator

@johnhbenetech as per docs - the sender identity has to be verified https://sendgrid.com/docs/for-developers/sending-email/sender-identity/

@johnhbenetech
Copy link
Collaborator

@jkondrat

Yes, let's just include it in the body, The from address can be '[email protected]'

@jkondrat
Copy link
Collaborator

jkondrat commented Feb 23, 2021

@johnhbenetech I was able to use reply-to header, is this sufficient? the delivered email looks like this:
Screenshot from 2021-02-23 18-55-38
Screenshot from 2021-02-23 18-54-31

@johnhbenetech
Copy link
Collaborator

@jkondrat looks good

awalkowiak added a commit that referenced this issue Feb 24, 2021
#1752: Use feedback receiver address as 'from' ema…
@abaranowska1
Copy link
Author

Feedback emails are sent properly once again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working estimated Story Points: 2
Projects
None yet
Development

No branches or pull requests

3 participants