Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open_datatree_from_Zarr (?) #171

Open
aladinor opened this issue Apr 10, 2024 · 2 comments
Open

open_datatree_from_Zarr (?) #171

aladinor opened this issue Apr 10, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@aladinor
Copy link
Member

aladinor commented Apr 10, 2024

  • xradar version: 0.5.0
  • Python version:3.12
  • Operating System:Ubunut 22.04

Description

Hi everyone,

I was wondering if we should create an io method that allows us to read zarr back to xradar. Something like xradar.io.open_zarr given that we can now store/save the xradar hierarchical structure object using zarr.

Please let me know your thoughts.

@aladinor aladinor added the enhancement New feature or request label Apr 10, 2024
@kmuehlbauer
Copy link
Collaborator

@aladinor doesn't this work out-of-the-box with datatree? If I'm reading the documentation https://xarray-datatree.readthedocs.io/en/latest/io.html?highlight=zarr#zarr this should just work, no?

There is also work currently to integrate datatree into xarray pushed by NASA, NSIDC:
https://github.com/pydata/xarray/projects/9

There is a weekly open dev meeting for that purpose, if you are interested:
pydata/xarray#8747

But good chance I'm missing something, so please give a bit more detail.

@aladinor
Copy link
Member Author

aladinor commented Apr 12, 2024

Hi @kmuehlbauer. Well, I was thinking of a wrapper that uses datatree functionality to read Zarr files back into xradar. I'm not sure if I could call it a "backend" for reading Zarr files within xradar. Currently, if we want to read data, we have to use datatree.open_datatree, which is okay, but I was thinking of something like xradar.io.open_datatree. I wasn't thinking about a whole development. Sorry for the misunderstanding.

Something like

def open_datatree(path, **kwargs):
    """Function that opens datatree within xradar"""
    return datatree.open_datatree(path, kwargs)

Let me know your thoughts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants