Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(tests) O3-4098 Add tests for downloading a schema #19

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

CynthiaKamau
Copy link
Collaborator

Requirements

  • This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Related Issue

Other


it('handles downloading the schema', async () => {
const mocks = setupMocks();

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. 'here i would say it ("downloads the schema when the download button is clicked') to be more more descriptive, though it doesnt make any diff

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@CynthiaKamau CynthiaKamau merged commit f63ac0d into main Nov 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants