-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tune Landcover MIN_PIXEL_SIZE_THRESHOLDS to better resemble OpenMapTiles #94
base: main
Are you sure you want to change the base?
Conversation
Actually, on the whole planet and even up to only zoom level 11, the size increase is ~20%. Maybe this should be made configurable somehow. |
Thanks! I think planetiler-openmaptiles should default to parity with openmaptiles. If there's an option you should have to opt into the different version. One other thing to look at is simplify tolerances. Planetiler-openmaptiles simplifies less than openmaptiles. You might try reducing the tolerance on these features at lower zooms to see if that mitigates the size increase? |
https://github.com/openmaptiles/planetiler-openmaptiles/actions/runs/5771688860 ℹ️ Base Logs dd54543
ℹ️ This Branch Logs 12be7f50fb1fba9a33bdf70521efa95c263cfb56
|
Looking at openmaptiles https://github.com/openmaptiles/openmaptiles/blob/master/layers/landcover/generalized.sql I see:
This makes it look like we should just use min pixel size of 2 for all of them? They had gotten hanged in openmaptiles/openmaptiles#1413 which we must have missed. |
Thanks, I'll have a look in the next days, especially if tolerance can be tuned. Maybe also into |
Do you still plan to work on this? If not, I'd prefer to close this. |
Is this still even an issue? I thought the latest version updated these? |
Landover changes proposed here are not in the But yes, some other stuff was tweaked when porting 3.15 changes from SQL to Java, for example Landuse. |
I'm fine if this is not accepted, but I spotted differences compared to OpenMapTiles and it seems that this tunes it to be sufficiently similar. It does make the output about 10% larger (tested on Slovenia).
For reference attaching a screenshot what this is fixing (left OpenMapTiles, right Planetiler before the fix)