Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core data packages failed validation in the frontend #418

Open
4 tasks
Mikanebu opened this issue Jun 7, 2017 · 0 comments
Open
4 tasks

Core data packages failed validation in the frontend #418

Mikanebu opened this issue Jun 7, 2017 · 0 comments

Comments

@Mikanebu
Copy link

Mikanebu commented Jun 7, 2017

Some core data packages failed validation in the frontend. Preview is not working in showcase page

Acceptance Criteria

  • Preview in showcase page works fine
  • Validation passes in the frontend

Tasks

  • Fix packages in the upstream where it can be fixable
  • Analyse data packages validation in the dpr-js for string type

Analysis

Analysed 57 core data packaged which are published in the staging.datapaged.com.
17 core data packages have an error in the showcase page. Preview is not working
Error messages are related to the type property in the schema(metadata).
Somehow when "type"="string": validation gives an error for numbers like: 17, 1.5 etc.
Example: Wrong type for header: Company Name and value: 1
Probably js validation has a bug since it cannot accept numbers.
The list of core data packages can be found in the following spreadsheet:
https://docs.google.com/spreadsheets/d/14kJluhePaMOx6vYBic0poVjDYK3I8-v_xF3sv4Focac/edit#gid=1881654332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant