2058 status page redesign #2096
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by E2E-Test |
pmolnar-dev
reviewed
Nov 14, 2024
| <Chip | ||
| label="N/A" | ||
| sx={{ | ||
| backgroundColor: "rgba(23, 68, 229, 0.1)", |
There was a problem hiding this comment.
here I would suggest to insert both colors in the theme.js I already did that for my task and I named them like this: primaryBlue: alpha("#1744e51a", 0.1), darkGrey: "#3f434d". Then you can use sx={(theme) => ({ backgroundColor: theme.palette.primaryBlue, color: theme.palette.darkGrey })}
| <Chip | ||
| label={strings.status.connected} | ||
| sx={{ | ||
| backgroundColor: "rgba(23, 68, 229, 0.1)", |
There was a problem hiding this comment.
same as comment before
| font-size: 0.75rem; | ||
| line-height: 1.05rem; | ||
| vertical-align: top; | ||
| border-bottom: 1px solid rgba(63, 67, 77, 0.1); |
There was a problem hiding this comment.
I would use separate border-color and add it like this: border-color: var(--mui-palette-menuBorder) and in theme it is menuBorder: alpha("#3f434d1a", 0.1),
| font-weight: 400; | ||
| font-size: 0.875rem; | ||
| line-height: 1.269rem; | ||
| border-bottom: 1px solid rgba(63, 67, 77, 0.1); |
There was a problem hiding this comment.
same as previous comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
How to test
Closes #2058