Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: THzTools: data analysis software for terahertz time-domain spectroscopy #7521

Closed
editorialbot opened this issue Nov 23, 2024 · 30 comments
Assignees
Labels
pre-review pyOpenSci Submissions associated with pyOpenSci Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Nov 23, 2024

Submitting author: @jsdodge (J. Steven Dodge)
Repository: https://github.com/dodge-research-group/thztools
Branch with paper.md (empty if default branch): main
Version: v0.5.5
Editor: @crvernon
Reviewers: @crvernon
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/228f65ed74c96fbea91ebe80a5c3427c"><img src="https://joss.theoj.org/papers/228f65ed74c96fbea91ebe80a5c3427c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/228f65ed74c96fbea91ebe80a5c3427c/status.svg)](https://joss.theoj.org/papers/228f65ed74c96fbea91ebe80a5c3427c)

Author instructions

Thanks for submitting your paper to JOSS @jsdodge. Currently, there isn't a JOSS editor assigned to your paper.

@jsdodge if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Nov 23, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1017/9780511734809 is OK
- 10.1109/IRMMW-THz50927.2022.9895812 is OK
- 10.5281/zenodo.4326594 is OK
- 10.1109/IRMMW-THz50926.2021.9567242 is OK
- 10.1007/s10762-023-00947-w is OK
- 10.1364/OE.417724 is OK
- 10.1109/IRMMW-THz50926.2021.9566941 is OK
- 10.1063/1.5047659 is OK
- 10.1109/TTHZ.2018.2889227 is OK
- 10.48550/arXiv.2403.04332 is OK
- 10.1021/acs.analchem.1c02132 is OK

🟡 SKIP DOIs

- None

❌ MISSING DOIs

- 10.1109/irmmw-thz57677.2023.10299169 may be a valid DOI for title: From Noise Analysis to Error Bars on Refractive In...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.06 s (1510.9 files/s, 231043.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              2              0              2           6444
Python                           7            558           1483           3055
Markdown                         5            150              0            537
reStructuredText                54            286            221            310
YAML                            10             28              9            255
Jupyter Notebook                 6              0            837            191
TOML                             1             18              0            156
TeX                              1             11              0            112
XML                              8              0              0            104
DOS Batch                        1              8              1             26
JSON                             1              0              0             11
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            97           1063           2560          11210
-------------------------------------------------------------------------------

Commit count by author:

   511	jsdodge
    93	Steve Dodge
    59	jonathan Posada Loaiza
    36	jonathan.posada1
    28	Santiago Higuera Quintero
    20	Naod Yimam
    19	jonathanpl20
    18	Randon Hall
     9	Alireza
     5	“Roboboy2000”
     1	Leya
     1	unknown

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 443

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@danielskatz
Copy link

👋 @jsdodge - thanks for your submission. You may have seen that our DOI checker has found a citation in your .bib file without a DOI. Given that you don't use this in the paper, you can either add the DOI or remove it from the .bib file.

Once you do either one, please use the command @editorialbot check references to check again. editorialbot commands need to be the first entry in a new comment.

@jsdodge
Copy link

jsdodge commented Nov 23, 2024

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1017/9780511734809 is OK
- 10.1109/IRMMW-THz50927.2022.9895812 is OK
- 10.5281/zenodo.4326594 is OK
- 10.1109/IRMMW-THz50926.2021.9567242 is OK
- 10.1007/s10762-023-00947-w is OK
- 10.1364/OE.417724 is OK
- 10.1109/IRMMW-THz50926.2021.9566941 is OK
- 10.1063/1.5047659 is OK
- 10.1109/TTHZ.2018.2889227 is OK
- 10.1109/IRMMW-THz57677.2023.10299169 is OK
- 10.48550/arXiv.2403.04332 is OK
- 10.1021/acs.analchem.1c02132 is OK

🟡 SKIP DOIs

- None

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@danielskatz
Copy link

Thanks @jsdodge - We're having some internal discussion about which JOSS track this should be in, and once we decide, the appropriate track editor will start working on finding an editor.

@editorialbot editorialbot added Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning and removed Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Nov 25, 2024
@crvernon
Copy link

@editorialbot invite @bmcfee as editor

👋 @bmcfee - can you take this one on as editor? Thanks!

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@bmcfee
Copy link

bmcfee commented Nov 27, 2024

Sorry, I don't think I can add this one to my stack right now.

@banesullivan
Copy link

Hey howdy JOSS team, I'd like to chime in from PyOpenSci that THzTools has been accepted through PyOpenSci's review process and I believe that helps streamline the review process for JOSS.

PyOpenSci THzTools review: pyOpenSci/software-submission#209

@danielskatz
Copy link

@banesullivan - thanks, I missed this initially. Yes, in this case we can make this much simpler. @crvernon or I can do the work ourselves without needed another editor.

@jsdodge
Copy link

jsdodge commented Nov 30, 2024

Excellent, thanks!

@crvernon crvernon added the pyOpenSci Submissions associated with pyOpenSci label Dec 2, 2024
@crvernon
Copy link

crvernon commented Dec 2, 2024

As a note for the record:

PyOpenSci THzTools review: pyOpenSci/software-submission#209

@crvernon
Copy link

crvernon commented Dec 2, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

Can't start a review without reviewers

@crvernon
Copy link

crvernon commented Dec 2, 2024

@editorialbot add me as reviewer

@editorialbot
Copy link
Collaborator Author

Can't add reviewers: There is no editor assigned yet

@crvernon
Copy link

crvernon commented Dec 2, 2024

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @crvernon is now the editor

@crvernon
Copy link

crvernon commented Dec 2, 2024

@editorialbot add me as reviewer

@crvernon
Copy link

crvernon commented Dec 2, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

Can't start a review without reviewers

@crvernon
Copy link

crvernon commented Dec 2, 2024

@editorialbot add @crvernon as reviewer

@editorialbot
Copy link
Collaborator Author

@crvernon added to the reviewers list!

@crvernon
Copy link

crvernon commented Dec 2, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7542.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review pyOpenSci Submissions associated with pyOpenSci Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

6 participants