[PRE REVIEW]: PySDM v1: particle-based cloud modelling package for warm-rain microphysics and aqueous chemistry

[whedon]

Submitting author: @piotrbartman (Piotr Bartman)
Repository: https://github.com/atmos-cloud-sim-uj/PySDM.git
Version: v1
Editor: @dhhagan
Reviewers: @jwuttke, @darothen
Managing EiC: Kristen Thyng

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @piotrbartman. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @pdebuyl.

@piotrbartman if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

[whedon]

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

[whedon]

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.72 s (304.0 files/s, 17875.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                         210           2022           1194           7257
SVG                              1              0             19           1402
Jupyter Notebook                 3              0            207            336
Markdown                         1             33              0            270
YAML                             4             20              5            113
-------------------------------------------------------------------------------
SUM:                           219           2075           1425           9378
-------------------------------------------------------------------------------


Statistical information for the repository '540d532768b39be7feea8047' was
gathered on 2021/04/02.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Anna Jaruga                      1             3              1            0.01
Bartosz Piasecki                 1            42             23            0.09
Michael                         18           443            170            0.81
Michaeldz36                     37          2661           2424            6.76
Piotr Bartman                   10            14             19            0.04
Sylwester Arabas               391         11156           7135           24.30
piotrbartman                    61          2072           2853            6.54
prbartman                      438         26379          19740           61.27
tehAgitto                        4            84             51            0.18

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Bartosz Piasecki             30           71.4          4.5                0.00
Michael                     345           77.9         14.3                8.41
Sylwester Arabas           3856           34.6          3.3                4.67
prbartman                  6227           23.6          8.9                7.98
tehAgitto                    43           51.2          3.9                2.33

[whedon]

PDF failed to compile for issue #3144 with the following error:

Can't find any papers to compile :-(

[kthyng]

@whedon generate pdf from branch JOSS

[whedon]

Attempting PDF compilation from custom branch JOSS. Reticulating splines etc...

[whedon]

PDF failed to compile for issue #3144 with the following error:

/app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/lib/whedon.rb:147:in check_fields': Paper YAML header is missing expected fields: date (RuntimeError) from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/lib/whedon.rb:89:in initialize'
from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/lib/whedon/processor.rb:38:in new' from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/lib/whedon/processor.rb:38:in set_paper'
from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/bin/whedon:58:in prepare' from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/bin/whedon:131:in <top (required)>'
from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in

'

[kthyng]

@piotrbartman can you address the error in your paper here?

[kthyng]

@dhhagan Is this close enough in your wheelhouse to take on?

[kthyng]

@whedon invite @dhhagan as editor

[whedon]

@dhhagan has been invited to edit this submission.

[dhhagan]

@kthyng This is absolutely right in my wheelhouse - will add myself as editor.

[dhhagan]

@whedon assign @dhhagan as editor

[whedon]

OK, the editor is @dhhagan

[slayoo]

@whedon generate pdf from branch JOSS

[whedon]

Attempting PDF compilation from custom branch JOSS. Reticulating splines etc...

[whedon]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

[dhhagan]

Looks great - I'll find some reviewers over the next week or so (hopefully).

[dhhagan]

Hey @darothen - any chance you have some time for a review?

[dhhagan]

👋 Hey @sgrieve, @lheagy, @andreas-h, @jwuttke - would any of you be available and interested in reviewing this manuscript and software?

[jwuttke]

Where are the review instructions?

[slayoo]

Where are the review instructions?

https://joss.readthedocs.io/en/latest/reviewer_guidelines.html
https://joss.readthedocs.io/en/latest/review_criteria.html
https://joss.readthedocs.io/en/latest/review_checklist.html

Thanks,
Sylwester

[jwuttke]

OK, let me give it a try. How to get to the checklist?

[dhhagan]

Hey @jwuttke - once I find two reviewers, I will add them as reviewers in this issue, and a new review issue will be created that has the checklist for each reviewer. Would you like to review? If so, I will add you as one of the reviewers.

[jwuttke]

yes, I'm available.

[dhhagan]

@whedon add @jwuttke as reviewer

[whedon]

OK, @jwuttke is now a reviewer

[darothen]

Just saw this @slayoo and @dhhagan (buried in my notifications). I can offer a quick review.

[dhhagan]

@darothen Awesome. I'll add you and we can kick off this review!

[dhhagan]

@whedon add @darothen as reviewer.

[whedon]

OK, @darothen is now a reviewer

[dhhagan]

@whedon start review

[whedon]

OK, I've started the review over in #3219.

[darothen]

Thanks @dhhagan; will knock this out ASAP.