Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] no need to specify port and ports in config for RPC services #2895

Closed
morya opened this issue Nov 26, 2024 · 5 comments · Fixed by #2896
Closed

[BUG] no need to specify port and ports in config for RPC services #2895

morya opened this issue Nov 26, 2024 · 5 comments · Fixed by #2896
Labels
bug Categorizes issue or PR as related to a bug.

Comments

@morya
Copy link
Contributor

morya commented Nov 26, 2024

OpenIM Server Version

v3.8.0

Operating System and CPU Architecture

Linux (AMD)

Deployment Method

Source Code Deployment

Bug Description and Steps to Reproduce

rpc services are started and auto registered into registry ( zookeeper, etcd, k8s etc...),
listen IP and listen port are not that significant enough to be set in config file, it could be auto allocated random by system.

Screenshots Link

No response

@morya morya added the bug Categorizes issue or PR as related to a bug. label Nov 26, 2024
@morya
Copy link
Contributor Author

morya commented Nov 27, 2024

可能,有点代码坏味道,实现的略微粗糙点

@OpenIM-Robot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Maybe, it’s a bit of a bad code smell, and the implementation is a little rough.

@morya
Copy link
Contributor Author

morya commented Nov 27, 2024

there are bug existing, msggateway will fail to start,

@morya
Copy link
Contributor Author

morya commented Nov 28, 2024

there are bug existing, msggateway will fail to start,

ok, it's caused by config file error. no need to fix.

@icey-yu
Copy link
Member

icey-yu commented Dec 4, 2024

Thank you for your PR. I believe this solution is quite valuable, but there is still a small issue that needs to be addressed: there is a risk of port conflicts between the various components and the exposed Prometheus scraping ports, as they are started asynchronously. We are currently considering a solution to resolve this issue.

github-merge-queue bot pushed a commit that referenced this issue Dec 4, 2024
* fix: minor log typo

* fix: #2895 no need to specify listen port in config file, just use system random

* drop useless code
OpenIM-Robot pushed a commit that referenced this issue Dec 12, 2024
* fix: minor log typo

* fix: #2895 no need to specify listen port in config file, just use system random

* drop useless code
OpenIM-Robot pushed a commit that referenced this issue Dec 12, 2024
* fix: minor log typo

* fix: #2895 no need to specify listen port in config file, just use system random

* drop useless code
OpenIM-Robot pushed a commit that referenced this issue Dec 12, 2024
* fix: minor log typo

* fix: #2895 no need to specify listen port in config file, just use system random

* drop useless code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants