Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add send email test #254

Merged
merged 8 commits into from
Nov 3, 2023
Merged

feat: add send email test #254

merged 8 commits into from
Nov 3, 2023

Conversation

luhaoling
Copy link
Contributor


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #253

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@luhaoling luhaoling requested review from cubxxw and a team as code owners November 3, 2023 02:48
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 3, 2023
@luhaoling luhaoling temporarily deployed to openim November 3, 2023 02:49 — with GitHub Actions Inactive
@luhaoling luhaoling temporarily deployed to openim November 3, 2023 02:49 — with GitHub Actions Inactive
@luhaoling luhaoling temporarily deployed to openim November 3, 2023 02:49 — with GitHub Actions Inactive
Copy link

sweep-ai bot commented Nov 3, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@cubxxw cubxxw enabled auto-merge November 3, 2023 02:55
@cubxxw cubxxw added this pull request to the merge queue Nov 3, 2023
Merged via the queue into openimsdk:main with commit 595d5f3 Nov 3, 2023
11 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants