Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: There is no local binary during make start #209

Closed
DreamerXXT opened this issue Sep 18, 2023 · 4 comments · Fixed by #224
Closed

Bug: There is no local binary during make start #209

DreamerXXT opened this issue Sep 18, 2023 · 4 comments · Fixed by #224
Labels
bug Categorizes issue or PR as related to a bug. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@DreamerXXT
Copy link

DreamerXXT commented Sep 18, 2023

What happened?

There is no local binary during make start
Two scenarios:

  1. Display successful startup status, but report an error during detection (detection script shows no startup)
  2. Make start detects whether there are binaries locally, and if there are none locally, yes

What did you expect to happen?

  1. Make start to determine whether the binary system is started and modify it based on its status
  2. Scenario 2 can only make build first and then make start

How can we reproduce it (as minimally and precisely as possible)?

make start

Anything else we need to know?

No response

version

```console $ {name} version # paste output here ```

Cloud provider

OS version

```console # On Linux: $ cat /etc/os-release # paste output here $ uname -a # paste output here # On Windows: C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture # paste output here ```

Install tools

@DreamerXXT DreamerXXT added the bug Categorizes issue or PR as related to a bug. label Sep 18, 2023
@cubxxw
Copy link
Contributor

cubxxw commented Sep 18, 2023

This OpenIM Chat Issue

@cubxxw cubxxw transferred this issue from openimsdk/open-im-server Sep 18, 2023
@cubxxw
Copy link
Contributor

cubxxw commented Sep 20, 2023

  1. make start 添加一个逻辑, 检测是否执行过 make build 构建了二进制,如果发现没有构建,就先构建,再启动
  2. make check 修复逻辑,按照真实的进程去检测

@cubxxw cubxxw added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Sep 30, 2023
@kubbot
Copy link
Contributor

kubbot commented Sep 30, 2023

This issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨
Join slack 🤖 to connect and communicate with our developers.
If you wish to accept this assignment, please leave a comment in the comments section: /accept.🎯

@CNCSMonster
Copy link
Contributor

/accept

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
4 participants