Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support docker secrets (or pseudo-secrets) #116

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

edarchis
Copy link
Member

If the password variables are specified as file paths, the content of said paths will be loaded into the variable. This avoids having secrets in the environment.

If the password variables are specified as file paths, the content of said paths will be loaded into the variable. This avoids having secrets in the environment.
@gitguardian
Copy link

gitguardian bot commented Nov 24, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
3700481 Django Secret Key 68197af openIMIS/openIMIS/settings.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@edarchis
Copy link
Member Author

It is complaining about the default secret key. I think that we should force a file for it and if it's empty, generate a random key.
When configuring from docker-compose, we could specify it externally.
Don't merge yet, I'll clean this up.

@dragos-dobre dragos-dobre marked this pull request as draft September 15, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant