7.2: please do not use hardcoded yacc

[kloczek]

openiked-portable/iked/CMakeLists.txt

Lines 142 to 146 in 81092ec

	add_custom_command(
	OUTPUT parse.c
	COMMAND yacc -o parse.c ${CMAKE_CURRENT_SOURCE_DIR}/parse.y
	DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/parse.y
	)

This should be implemented using https://cmake.org/cmake/help/latest/module/FindFLEX.html

[tobhe]

Thanks, I wasn't aware of that cmake feature! This looks a lot better than the current hack.

[tobhe]

One problem I am running into is that this cmake module doesn't find the yacc versions shipped in base by most BSD systems.

[kloczek]

What about bison? 🤔

[tobhe]

bison would require installing an external package which I find unfortunate because iked builds fine with what is available in the base installation. Maybe we need a FindYACC and fallback to bison if that isn't there.

[kloczek]

Currently most of the bison generated parses do not need flex static library on linking.

I'm not sure how it is with yacc on *BSD but generally speaking yacc on Linux is way behind GNU bison and everything what theoretically needs yacc always is possible to build bison.