Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Cryptography Instructions #285

Open
Daniyal-R-A opened this issue Nov 6, 2024 · 1 comment
Open

Issue with Cryptography Instructions #285

Daniyal-R-A opened this issue Nov 6, 2024 · 1 comment

Comments

@Daniyal-R-A
Copy link
Contributor

Daniyal-R-A commented Nov 6, 2024

Make sim is giving error, if two extensions have same instructions. But as suggested in the 000_RISCV_summary-bitmanip_amo.pdf
"Zknd and Zkne (RV64 only): AES Key Schedule" has the same Instructions as shown below:
image

Same issue with Zbkb extension as it saying that it "also includes rolw, rorw, rorrwi, Table I.23, which are instructions for Zbb RV64:
image

Also no instructions are listed for Zbkc extension:
image

@davidharrishmc
Copy link
Collaborator

davidharrishmc commented Nov 7, 2024

These instructions that belong to multiple extensions only need to be tested once, so they don't need to be generated more than once. Let's keep this issue open. Once the tests are created, let's think about the best way to run the appropriate tests for the appropriate extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants