Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuItems should not have any focus ring #244

Open
herhuey opened this issue Feb 17, 2023 · 1 comment
Open

MenuItems should not have any focus ring #244

herhuey opened this issue Feb 17, 2023 · 1 comment

Comments

@herhuey
Copy link

herhuey commented Feb 17, 2023

Describe the bug
Onhover shows focus ring in some instances and no focus ring in other instances (view screenshots).

From Kar Rui: focus only shows using the :focus-visible selector, which may have been triggered when you open (since programatic focus === focus-visible)

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://design.hack.gov.sg/?path=/docs/components-menu--docs
  2. Hover over any MenuItem and note the current focus ring behaviour
  3. (repeat until focus ring behaviour changes from 2.) Refresh page OR open MenuDefault at the top of the page and hover over its items OR leave it there for a while and come back later => hover over any MenuItems to check focus ring behaviour

Expected behavior
MenuItems should not show any focus ring.

Screenshots
image
image

Desktop (please complete the following information):

  • OS: macOS Ventura 13.1
  • Browser: Chrome
  • Version 109.0.5414.119 (Official Build) (x86_64)
@seaerchin
Copy link

i found that this bug could be reliably triggered by using tab (on keyboard) then after, using mouse to hover triggers the focus ring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants