Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown options rendering outside of form creation tab #6597

Open
LeonardYam opened this issue Aug 5, 2023 · 5 comments
Open

Dropdown options rendering outside of form creation tab #6597

LeonardYam opened this issue Aug 5, 2023 · 5 comments

Comments

@LeonardYam
Copy link
Contributor

Description

Dropdown options are not handled by overflow properties properly due to the FloatingPortal, leading to buggy behaviour in the form creation tab.

Related to #6026

To Reproduce
Steps to reproduce the behavior:

  1. Create a form of suitable length with a dropdown field
  2. Open the dropdown options
  3. Scroll up past the dropdown options
  4. See error

Expected behavior
Dropdown options should be hidden

Screenshots

floatingportal.mp4
@LeonardYam
Copy link
Contributor Author

Hi @foochifa, I discovered another bug caused by the usage of FloatingPortal. I believe other than removing FloatingPortal, the only alternative to fix this would be to add overflow: hidden into the document body which should be avoided.

Let me know if I should open another PR or include the fix in #6501!

@foochifa
Copy link
Contributor

foochifa commented Aug 7, 2023

Hmm @LeonardYam I can't seem to replicate this issue on both dev and production.

Did you face this on the develop branch? If possible could you show a screenshot with the chrome dev tools elements opened, and panned to the whitespace?

@LeonardYam
Copy link
Contributor Author

Hi @foochifa, I have been able to replicate this on the updated develop branch. Just to be safe, I tested this on both Firefox and Chrome so I believe this is not a browser compatibility issue.

Firefox:
image

Chrome:
image

@foochifa
Copy link
Contributor

foochifa commented Aug 8, 2023

Hmm.. may I check what's the floating-ui and downshift version currently in your environment? And also the device you are currently using?

As this is what we currently see:

Screen.Recording.2023-08-08.at.2.10.04.PM.mov

@LeonardYam
Copy link
Contributor Author

Hi @foochifa, according to my node_modules, floating-ui is 0.9.3 and downshift is 7.3.2. This bug occurred on my M1 Mac and Windows 11 PC.

I'm not too sure why it's only showing up for me 🤕.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants