-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/include qm #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, thanks
Can you update the sphinx documentation ?
Thnaks. Still, I'm a bit confused about failing tests 🤔.
Done. |
Indeed something is wrong https://github.com/opengisch/qgis-plugin-ci/pull/85/checks?check_run_id=3438077538#step:7:226 |
I am wondering if we should not go a bit further. The transifex integration has always been a pain in plugin-ci (we rely on a self-made Python lib for it, it prevents from running parallel test jobs). For the translations, at the moment we cannot avoid using a sub-process to update and compile strings (see https://github.com/opengisch/qgis-plugin-ci/blob/master/qgispluginci/translation.py#L125-L143). So I am wondering if we should not just make the translation completely agnostic of any platform. The only drawback of this would be that the project won't be created automatically anymore on Transifex (which is super useful to me as I don't need to head to transifex at all). Thoughts? |
I completely agree. The tool creates an amalgam between translation management and a third party service (transifex). Besides, the ecosystem now seems to react positively to the emergence of weblate and it's a shame not to offer it or rather to impose transifex. More globally, the tool is currently very much imprinted with our respective development habits whereas I think it would gain in adoption to be more generic/agnostic. But I think it implies a refactoring. |
Furthermore, speaking of this (almost stale) PR, I've managed my needs by manipulating the gitignore to include qm files without adding them to the tracking files (let's argue against binary files into a git repo). Workflow example: |
To add to the topic, we lately changed our habits. |
Close #47
This PR: