Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this repository match the published version? #14

Closed
PeterParslow opened this issue Jul 24, 2024 · 9 comments · May be fixed by #16
Closed

Does this repository match the published version? #14

PeterParslow opened this issue Jul 24, 2024 · 9 comments · May be fixed by #16
Assignees

Comments

@PeterParslow
Copy link
Collaborator

The repository's readme says

"This version is based upon Edition 3 Draft, in which Review/comments were invited by 31 October 2021. "

The published version (https://standards.unggim.ogc.org/index.php) is Edition 3.0.0:2022-01-01.

If we publish again from this repository, will we lose whatever changed between the October 2021 draft and the January 2022 publication?

I've tried looking at some bits, and not all look the same. For example, the Appendix titles at https://standards.unggim.ogc.org/index.php are different to those in the adoc files in https://github.com/opengeospatial/unggim_standards_guide/tree/main/Appendices - but I'm not sure those files are used in the published online guide, where the appendices are linked spreadsheets rather than HTML files.

@ogcscotts
Copy link
Contributor

request for republication has been made

@PeterParslow
Copy link
Collaborator Author

request for republication has been made

https://standards.unggim.ogc.org/unggim_guide.html still has "ISO 19169" for API Features...

@ogcscotts
Copy link
Contributor

published: https://standards.unggim.ogc.org/index.php

@PeterParslow
Copy link
Collaborator Author

PeterParslow commented Aug 14, 2024

Looks good. Which can't be said of the PDF version which is linked & contains the corrections, but also contains a lot of unprocessed HTML tags in places. That should perhaps be a new issue "some HTML tags not handled in PDF publishing"?

@PeterParslow PeterParslow linked a pull request Aug 14, 2024 that will close this issue
@PeterParslow
Copy link
Collaborator Author

@ogcscotts : is there anything we (you, Greg?) can do about the html tags in the PDF?

@ogcscotts
Copy link
Contributor

@gbuehler does Asciidoctor-pdf have a problem with HTML tags that include the window="_blank" modifier?

@gbuehler
Copy link
Contributor

Per https://docs.asciidoctor.org/asciidoc/latest/macros/link-macro-attribute-parsing/

the Asciidoc should be window=_blank without the quotes.

@gbuehler
Copy link
Contributor

gbuehler commented Dec 13, 2024

Note that this fix did not exactly work.

So what I did was for the PDF version only I did a search and replace for , window=_blank with '' then I ran the command:

asciidoctor-pdf -o unggim_guide.pdf unggim.adoc

and posted that document. The repo still contains all the , window=_blank as that is needed for the HTML.

@PeterParslow
Copy link
Collaborator Author

Thanks, Greg, for sorting that out - The PDF likes good now.

Those instructions should be stored somewhere for future use, e.g. after the IHO meeting in March that should consider / decide on #6. I've summarised in the Readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants