Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematron to be included in the test #27

Closed
bermud opened this issue Mar 14, 2016 · 13 comments · May be fixed by #69
Closed

Schematron to be included in the test #27

bermud opened this issue Mar 14, 2016 · 13 comments · May be fixed by #69
Assignees

Comments

@bermud
Copy link
Contributor

bermud commented Mar 14, 2016

Check that this schematron is included in the test
http://schemas.opengis.net/wmts/1.0/profiles/wmts-simple/

@keshavnangare
Copy link

keshavnangare commented Mar 24, 2020

@dstenger

I went through test implementation but unable to find references for Schematron.
I think Schematron is not used in this test.

@dstenger
Copy link
Contributor

Can you please check if it is possible to include schematrons in this test suite (beware, it is CTL)?

@keshavnangare
Copy link

@dstenger
Copy link
Contributor

The provided Schematron can be used to test the WMTS Simple Profile but not the implementation standard itself (see https://www.ogc.org/standards/wmts).

@ghobona We should check if a test of the simple profile can be integrated into the test suite.

@ghobona
Copy link
Contributor

ghobona commented Jul 9, 2020

@dstenger

We should integrate the WMTS Simple Profile into the existing WMTS ETS.

I will ask @keshav-nangare to proceed with the integration.

@ghobona ghobona removed the question label Jul 9, 2020
@ghobona ghobona removed their assignment Jul 9, 2020
@ghobona
Copy link
Contributor

ghobona commented Jul 22, 2020

Discussion on 2020-07-22, @keshav-nangare to add the schematron in a separate test in the WMTS test suite.

@keshavnangare
Copy link

@dstenger @ghobona

Following are my findings:

  • I faced some issues while loading Schematron referred in the first comment:
    1. The namespace for Schematron currently refers to http://purl.oclc.org/dsdl/schematron.
    2. It does not define any phase which can execute the pattern and the element value-of is having a problem as below:
      Line 30 - element "sch:value-of" not allowed here; expected the element end-tag, text, element "sch:dir", "sch:emph", "sch:name" or "sch:span" or an element from another namespace
  • I have updated the Schematron as per below which loads successfully.
    1. The namespace should be changed to http://www.ascc.net/xml/schematron.
    2. Added the DefaultPhase and removed the value-of element statement.

Let me know your thought on this.

@keshavnangare
Copy link

@dstenger @ghobona

I have investigated the Schematron issue with ISO namespace and found a problem with our SchematronParser library. Currently, TE SchematronValidatingParser.java using jing library to validate Schematron as per investigation it is not supporting the latest ISO Schematron. Also, I found a similar issue(# 258) opened in their GitHub repository.

Should we use different libraries to validate ISO Schematron? What is your opinion on this?

@ghobona
Copy link
Contributor

ghobona commented Jul 31, 2020

I would suggest creating a separate class called ISOSchematronValidatingParser.java, then using ph-schematron with the new class.

@dstenger
Copy link
Contributor

dstenger commented Aug 5, 2020

@keshav-nangare Please create a new issue in TEAM Engine tracker and implement an ISOSchematronValidatingParser as suggested in comment #27 (comment).

@dstenger
Copy link
Contributor

ph-schematron uses Saxon-HE. Thus, opengeospatial/teamengine#32 must be solved first.

Alternatively, we can check if there is another schematron library.

@keshavnangare
Copy link

The changes for the Schematron are included in the #69 PR.

@ghobona
Copy link
Contributor

ghobona commented Jan 12, 2023

This issue has been overtaken by events.

@ghobona ghobona closed this as completed Jan 12, 2023
@dstenger dstenger added this to CITE Aug 1, 2024
@dstenger dstenger moved this to Done in CITE Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants