-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance when visiting all feature instances #61
Comments
Thank you for the feedback. @jyutzler What are your thoughts about this? |
The idea certainly has merit but I don't know the right way to do this within the current architecture. |
Note that as part of #70 I reduced some file sizes so that our own unit tests would complete faster. |
This is currently assigned to me but I am not aware of any action that I can take at this time. Please update and/or re-assign. |
It can be checked whether pull request ajanett#1 solves this issue. If this is the case, this issue can be closed. |
ajanett#1 is not merged into this repository. We should check whether we want to migrate the code. |
In order to accomplish tests 12-128r14 19, 20, 32, 33, 67, 78 and also NSG Requirement 19B, we have to look at each feature instance, and examine the geometry blob for each one. Well, performance for this is a bit of a problem. The tests can run for a loooong time in a geodatabase having a substantial number of feature instances, and there simply is not much being reported to let an operator know that the tests are still running.
If test #66 (examining the entire geometry WKB) is to be added, performance would suffer substantially more.
Generally, if a test is going to fail for a feature, it'll fail for all instances of a feature. (Unfortunately, that is not always the case and I have seen a geopackage fail one of these tests at row 14,000 or so) If there is some option we can allow to perform a 'quick-test', looking the first 100 instances of each feature; vs. a full test, That would certainly help with performance significantly.
The text was updated successfully, but these errors were encountered: