Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance when visiting all feature instances #61

Open
ajanett opened this issue May 22, 2018 · 6 comments
Open

Performance when visiting all feature instances #61

ajanett opened this issue May 22, 2018 · 6 comments
Assignees

Comments

@ajanett
Copy link
Contributor

ajanett commented May 22, 2018

In order to accomplish tests 12-128r14 19, 20, 32, 33, 67, 78 and also NSG Requirement 19B, we have to look at each feature instance, and examine the geometry blob for each one. Well, performance for this is a bit of a problem. The tests can run for a loooong time in a geodatabase having a substantial number of feature instances, and there simply is not much being reported to let an operator know that the tests are still running.

If test #66 (examining the entire geometry WKB) is to be added, performance would suffer substantially more.

Generally, if a test is going to fail for a feature, it'll fail for all instances of a feature. (Unfortunately, that is not always the case and I have seen a geopackage fail one of these tests at row 14,000 or so) If there is some option we can allow to perform a 'quick-test', looking the first 100 instances of each feature; vs. a full test, That would certainly help with performance significantly.

@dstenger
Copy link
Contributor

Thank you for the feedback.

@jyutzler What are your thoughts about this?

@jyutzler
Copy link
Contributor

The idea certainly has merit but I don't know the right way to do this within the current architecture.

@jyutzler
Copy link
Contributor

Note that as part of #70 I reduced some file sizes so that our own unit tests would complete faster.

@jyutzler
Copy link
Contributor

This is currently assigned to me but I am not aware of any action that I can take at this time. Please update and/or re-assign.

@dstenger
Copy link
Contributor

dstenger commented Jan 5, 2021

It can be checked whether pull request ajanett#1 solves this issue. If this is the case, this issue can be closed.

@dstenger dstenger removed their assignment Jan 5, 2021
@dstenger
Copy link
Contributor

dstenger commented Jan 6, 2021

ajanett#1 is not merged into this repository. We should check whether we want to migrate the code.

@dstenger dstenger added this to CITE Aug 1, 2024
@dstenger dstenger moved this to To do in CITE Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

No branches or pull requests

3 participants