Defer/fix some minor import issues #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwthompson
commented
Nov 6, 2024
| @@ -31,7 +31,6 @@ | |||
|
|
|||
| import numpy as np | |||
| from numpy.typing import NDArray | |||
| from openff.units import ensure_quantity | |||
There was a problem hiding this comment.
This method is in openff.units.openmm, which means importing it results in an import openmm call whenever anything in this module is imported. Obviously it's going to be in memory for many use cases, but it's unnecessary to import it here
j-wags
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm hunting down some issues with slow import times. Some are likely due to OpenMM sneaking in where it doesn't need to be (might be fixed upstream openforcefield/openff-units#97 (comment)) but I found a few other minor improvements when digging.