Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the internal AttributeXXX classes with attrs #226

Open
dotsdl opened this issue Apr 9, 2020 · 1 comment
Open

Replace the internal AttributeXXX classes with attrs #226

dotsdl opened this issue Apr 9, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request refactor

Comments

@dotsdl
Copy link
Member

dotsdl commented Apr 9, 2020

From @SimonBoothroyd:

The current AttributeClass and Attribute classes were mainly created to be flexible representations of data classes to be used when speccing out the new class designs as part of the openff-evaluator refactoring.

While these classes are flexible, extensible and allow new classes to be specced out easily, complete with automatic serialization support, automatic docstrings and a degree of automatic validation, they are not particularly performant and could (and should) likely be replace with / built on top of the existing attrs library.

Any replacement solution must provide the same level of flexibility, extensibility and automation, as well as being able to readily support polymorphic class designs.

@dotsdl dotsdl self-assigned this Apr 9, 2020
@dotsdl dotsdl added refactor enhancement New feature or request labels Apr 9, 2020
@dotsdl
Copy link
Member Author

dotsdl commented Jul 6, 2020

We have decided to pursue re-implementing these classes using pydantic over attrs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor
Projects
None yet
Development

No branches or pull requests

1 participant