Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter onboarding is flashing and jumping up #899

Closed
teolemon opened this issue Jan 8, 2022 · 0 comments · Fixed by #902
Closed

Parameter onboarding is flashing and jumping up #899

teolemon opened this issue Jan 8, 2022 · 0 comments · Fixed by #902
Assignees
@monsieurtanuki
Labels
🐛 bug Something isn't working food preferences 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…

Comments

@teolemon
Copy link
Member

teolemon commented Jan 8, 2022 •
edited
Loading

What

  • Parameter onboarding is flashing and jumping up on each setting change
  • There no way to collapse down the summary card after expanding it

Part of

Video

screen-20220108-114146.mp4
@teolemon teolemon added 🐛 bug Something isn't working food preferences 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… labels Jan 8, 2022
@monsieurtanuki monsieurtanuki self-assigned this Jan 8, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jan 8, 2022
@monsieurtanuki
fix: openfoodfacts#899 - avoid to reload the product in onboarding
9a2096d 
Impacted file:
* `preferences_page.dart`: split in two the process - load product and then display it with preferences
@monsieurtanuki monsieurtanuki mentioned this issue Jan 8, 2022
Merged
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jan 8, 2022
@monsieurtanuki
fix: openfoodfacts#899 - pubspec.yaml upgrade to openfoodfacts 1.9.1
774786b 
Impacted files:
* `smooth_app/pubspec.yaml`: upgrade to openfoodfacts 1.9.1
* `smooth_app/pubspec.lock`: impacted by pubspec.yaml
* `smooth_ui_library/pubspec.yaml`: upgrade to openfoodfacts 1.9.1
* `smooth_ui_library/pubspec.lock`: impacted by pubspec.yaml
* `smooth_ui_library/example/pubspec.lock`: impacted by pubspec.yaml
monsieurtanuki added a commit that referenced this issue Jan 9, 2022
@monsieurtanuki
fix: #899 - avoid to reload the product in onboarding (#902)
cb320e6 
Impacted file:
* `preferences_page.dart`: split in two the process - load product and then display it with preferences
* `smooth_app/pubspec.yaml`: upgrade to openfoodfacts 1.9.1
* `smooth_app/pubspec.lock`: impacted by pubspec.yaml
* `smooth_ui_library/pubspec.yaml`: upgrade to openfoodfacts 1.9.1
* `smooth_ui_library/pubspec.lock`: impacted by pubspec.yaml
* `smooth_ui_library/example/pubspec.lock`: impacted by pubspec.yaml
@github-actions github-actions bot mentioned this issue Jan 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
🐛 bug Something isn't working food preferences 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #899 - avoid to reload the product in onboarding monsieurtanuki/smooth-app
2 participants
@teolemon @monsieurtanuki