Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update tabs when a language is added from the photo details #5931

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Nov 25, 2024

Hi everyone,

If a photo is added to a new language from the photo details, the tabs in the gallery are not refreshed.
This is now fixed.

🎥 https://github.com/user-attachments/assets/cefb5428-8288-496d-93d5-7431a972d76e

@g123k g123k self-assigned this Nov 25, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 6.57%. Comparing base (4d9c7fc) to head (5ca0ce0).
Report is 517 commits behind head on develop.

Files with missing lines Patch % Lines
...oduct/gallery_view/product_image_gallery_tabs.dart 0.00% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5931      +/-   ##
==========================================
- Coverage     9.54%   6.57%   -2.97%     
==========================================
  Files          325     437     +112     
  Lines        16411   24669    +8258     
==========================================
+ Hits          1567    1623      +56     
- Misses       14844   23046    +8202     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@g123k g123k linked an issue Nov 25, 2024 that may be closed by this pull request
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☢️ 🦴

@teolemon teolemon merged commit df2961a into openfoodfacts:develop Nov 26, 2024
6 checks passed
@g123k g123k deleted the photo_gallery_tabs_fix branch November 28, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Photo gallery: adding a language in details doesn't add a tab
3 participants