Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 5864 - more verbose error message for details #5892

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Now for errors happening in background tasks regarding "edit product details", we consider status fields 'error' and 'status_verbose', in order to be more talkative.

Screenshot

Screenshot_1732205400

Part of

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 6.69%. Comparing base (4d9c7fc) to head (d4d3e76).
Report is 494 commits behind head on develop.

Files with missing lines Patch % Lines
...th_app/lib/background/background_task_details.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5892      +/-   ##
==========================================
- Coverage     9.54%   6.69%   -2.86%     
==========================================
  Files          325     434     +109     
  Lines        16411   24128    +7717     
==========================================
+ Hits          1567    1616      +49     
- Misses       14844   22512    +7668     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@g123k g123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we show both: error and verboseError?
Or is-it one or the other?

@monsieurtanuki
Copy link
Contributor Author

Shouldn't we show both: error and verboseError? Or is-it one or the other?

@g123k Fair enough: just pushed a fix.

Copy link
Collaborator

@g123k g123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@monsieurtanuki monsieurtanuki merged commit 5a38f01 into openfoodfacts:develop Nov 21, 2024
9 of 11 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @g123k for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants